[Bug 129789] starts playing when you click Next or Previous while paused

[rhythmbox (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=129789

  rhythmbox | User Interface | Ver: 0.8.8

Jonathan Matthew changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118748|none                        |needs-work
               Flag|                            |




------- Comment #11 from Jonathan Matthew  2008-09-15 22:13 UTC -------
The 'error' parameter to rb_shell_player_get_playing cannot be removed.  That
function is part of the dbus interface, so it needs to return a boolean
indicating success or failure, and to have a 'GError **' as its last parameter.

If you're adding new parameters to a function that takes a 'GError **'
parameter, they should go before it. By convention, a patameter used to return
a GError is the last parameter.

Actually, I don't think the 'open_and_play' parameter is required in most of
the places it's used here.  Instead, it should be a new value for the
PlaybackStartType enum.

Also, we don't use C++ style (// ...) comments.


Details of the patch aside, I don't really see much of a reason to make this
change.  Why is it useful to move to the next song without playing it?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=129789.