Bug#568477: Bug#581511: also needed for cups-pk-helper support

[Michael Biebl]

On 31.07.2010 13:34, Guido Günther wrote:
> On Fri, Jul 30, 2010 at 08:13:51PM +0200, Michael Biebl wrote:
>> As already said, I don't have any experience with python (packaging), but I find
>> it a bit strange that system-config-printer-kde uses API from
>> /usr/share/system-config-printer/. Isn't that internal to s-c-p?
> Looking at the system-config-printer-kde source it seems the only parts
> that are needed are from cusphelpers so this might turn out as a non
> issue after all.

Are you sure you are not looking at the patched sources of kdeadmin (see
01_system_config_printer_kde_cupsutils.diff)?

I found the following in system-config-printer-kde.py:

> #load modules from system-config-printer-common (debug, smburi), change path here if you have it installed elsewhere
> SYSTEM_CONFIG_PRINTER_DIR = "/usr/share/system-config-printer"
> if os.path.exists(SYSTEM_CONFIG_PRINTER_DIR + "/debug.py"):
>     sys.path.append(SYSTEM_CONFIG_PRINTER_DIR)
> 
> ...
> # These come from system-config-printer
> import config
> import cupshelpers, options
> from optionwidgets import OptionWidget
> from smburi import SMBURI
> from debug import *

An alternative solution to splitting s-c-p could be, to move the necessary
classes into python-cupshelpers. TBH I dunno which solution is better/cleaner.

Michael



-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20100731/44933c3d/attachment.pgp>