Bug#546837: More debug

[Stephan Peijnik]

On Sun, 2010-05-23 at 22:01 +0200, Julian Andres Klode wrote:
> On Sun, May 23, 2010 at 03:35:10PM -0400, Dominique Brazziel wrote:
> > 	Things keep getting odder and odder with this text parsing.
> > match_suffix.get_text(end) returns u'NNNNNN', where 'NNNNNN' is the
> > bug number, but when the string is appended to the url_prefix,
> > the 'u' appears in the first position of the array.  Both cases
> > the 'u' is unquoted:
> > 
> > [   DEBUG:UpdateManager.Util.procesinfo] url_prefix is
> > 'http://bugs.debian.org/'
> > [   DEBUG:UpdateManager.Util.procesinfo] match_suffix = <GtkTextIter at
> > 0xa620018>  match_end = <GtkTextIter at 0xa620050>
> > [   DEBUG:UpdateManager.Util.procesinfo]
> > match_suffix.get_text(match_end) returned u'531668'  <== u before bug #
> > [   DEBUG:UpdateManager.Util.procesinfo] url after appending
> > match_suffix.get_text is u'http://bugs.debian.org/531668'  <== huh?
> > 
> > Is the u some sort of attribute, for instance denoting underline?
> 
> http://docs.python.org/tutorial/introduction.html#unicode-strings

As Julian already mentioned, the u prefix of a string denotes a unicode
string. This did not cause the bug and conversion of this unicode string
to a non-unicode string is not needed.

The actual bug lies in the line
"command = ['sudo', '-u#' + pi.owner_ui, command]"

The pi.owner_ui attribute does not exist, this seems to stem from a typo
(oops). The correct name of the attribute is "owner_uid", so using
"pi.owner_uid" instead should fix the problem. I just committed revision
1570 in the update-manager bzr tree at alioth.d.o, which incorporates
that fix.

I will do a release of update-manager in the next few days which will
contain the fix mentioned above (and all other fixes currently included
in debian/patches/).

Anyways, thanks for working on this Dominique.

Regards,

Stephan

PS: Sorry for not having taken care of this earlier, but I'm a bit busy
with other things right now.