Bug#636323: notification-daemon: crashes on wrong type of 'transient' hint

[Michael Biebl]

Hi,

On 20.09.2011 16:50, anomie at users.sourceforge.net wrote:
> found 636323 0.7.2-1
> tags 636323 patch
> thanks
> 
> This patch against 0.7.2-1 seems to fix the problem. What it does is
> check the type of the incoming hint and use the appropriate
> g_variant_get_* function.
> 
> It also applies the same fix for the "resident" and "action-icons"
> hints.

Thanks for the patch.
I guess it makes some sense to treat values != 0 as true, while skipping
double values (ie. treat them as FALSE).

I'm not sure, if we have all those different variants for int values (in
my tests I always received int32), but it certainly doesn't hurt to test
against all of them.

Lastly, as I wanted to add proper credits to the patch header and the
debian changelog, I wanted to ask if this patch is by you and if I
should add your real name (google turns up Brad Jorsch for this email
address).


Cheers,
Michael




-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20111209/4d520a33/attachment.pgp>