Bug#643368: control-center: FTBFS: gnome-about-me-password.c:213:7: error: format not a string literal and no format arguments [-Werror=format-security]

[Didier Raboud]

Source: control-center
Version: 1:2.30.1-3
Severity: serious
Tags: wheezy sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> gcc -DHAVE_CONFIG_H -I. -I../.. -I../../capplets/common -pthread -DORBIT2=1 -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/cairo -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/libxml2 -I/usr/include/gnome-desktop-2.0 -I/usr/include/startup-notification-1.0   -I../../ -DG_LOG_DOMAIN="\"about-me-properties\"" -pthread -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -DCAMEL_HAVE_NSS -DCAMEL_HAVE_SSL -pthread -DORBIT2=1 -I/usr/include/nss -I/usr/include/nspr -I/usr/include/evolution-data-server-3.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/gconf/2 -I/usr/include/libsoup-2.4 -I/usr/include/orbit-2.0   -DDATADIR="\"/usr/share\"" -DGNOMECC_DATA_DIR="\"/usr/share/gnome-control-center\"" -DGNOMECC_UI_DIR="\"/usr/share/gnome-control-center/ui\"" -DGNOMECC_PIXMAP_DIR="\"/usr/share/gnome-control-center/pixmaps\"" -DGNOMELOCALEDIR="\"/usr/share/locale\""    -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -c gnome-about-me-password.c
> gnome-about-me-password.c: In function 'spawn_passwd':
> gnome-about-me-password.c:213:7: error: format not a string literal and no format arguments [-Werror=format-security]
> gnome-about-me-password.c: In function 'io_watch_stdout':
> gnome-about-me-password.c:430:14: warning: variable 'dialog' set but not used [-Wunused-but-set-variable]
> gnome-about-me-password.c: In function 'passdlg_error_dialog':
> gnome-about-me-password.c:720:7: error: format not a string literal and no format arguments [-Werror=format-security]
> gnome-about-me-password.c:726:10: error: format not a string literal and no format arguments [-Werror=format-security]
> gnome-about-me-password.c: In function 'passdlg_validate_passwords':
> gnome-about-me-password.c:870:14: warning: variable 'dialog' set but not used [-Wunused-but-set-variable]
> cc1: some warnings being treated as errors
> 
> make[6]: *** [gnome-about-me-password.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2011/09/23/control-center_1:2.30.1-3_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.