Bug#675342: gnome-settings-daemon - Assertion in wacom-plugin: (device->priv->styli)

[Bastian Blank]

On Thu, May 31, 2012 at 03:54:28PM +0200, Bastian Blank wrote:
> On Thu, May 31, 2012 at 03:09:21PM +0200, Michael Biebl wrote:
> > On 31.05.2012 14:36, Bastian Blank wrote:
> > > | wacom-plugin:ERROR:gsd-wacom-device.c:1491:gsd_wacom_device_set_current_stylus: assertion failed: (device->priv->styli)
> > > | x-session-manager[21447]: WARNING: App 'gnome-settings-daemon.desktop' respawning too quickly
> > This is most likely fixed by
> > http://git.gnome.org/browse/gnome-settings-daemon/commit/?h=gnome-3-4&id=45fe6b84f9b739b92823d7a63760f2cbd248418a
> Nope.

After reading the code I consider this not only a bug, but a fundamental
flaw: Plugins must not cause the daemon to abort.

There are two problems in one file:
- gsd-wacom-device.c:227
  In absence of a default clause, the compiler checks if all enum values
  are handled.  So this actually _hides_ errors.
- gsd-wacom-device.c:1494
  No guaranty that the value is ever set.

Bastian

-- 
The sooner our happiness together begins, the longer it will last.
		-- Miramanee, "The Paradise Syndrome", stardate 4842.6