Bug#713594: mssh: FTBFS: pango-font.h:380:33: error: ISO C restricts enumerator values to range of 'int' [-Wpedantic]

[Emilio Pozuelo Monfort]

On 29/06/13 12:20, Axel Beckert wrote:
> Control: reassign -1 libpango1.0-dev
> Control: affects -1 mssh
> 
> Hi,
> 
> David Suárez wrote:
>> Source: mssh
>> Version: 1.2-3
>> Severity: serious
>> Tags: jessie sid
>> User: debian-qa at lists.debian.org
>> Usertags: qa-ftbfs-20130620 qa-ftbfs
>> Justification: FTBFS on amd64
>>
>> Hi,
>>
>> During a rebuild of all packages in sid, your package failed to build on
>> amd64.
>>
>> Relevant part:
>>> gcc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libdrm -I/usr/include/harfbuzz -I/usr/include/gconf/2 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/vte-0.0    -D_FORTIFY_SOURCE=2 -pedantic-errors -Werror -Wall -Wfatal-errors -Wwrite-strings -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -c mssh.c
>>> In file included from /usr/include/pango-1.0/pango/pango-attributes.h:25:0,
>>>                  from /usr/include/pango-1.0/pango/pango.h:25,
>>>                  from /usr/include/gtk-2.0/gdk/gdktypes.h:37,
>>>                  from /usr/include/gtk-2.0/gdk/gdkscreen.h:32,
>>>                  from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:31,
>>>                  from /usr/include/gtk-2.0/gdk/gdk.h:32,
>>>                  from /usr/include/gtk-2.0/gtk/gtk.h:32,
>>>                  from mssh.c:7:
>>> /usr/include/pango-1.0/pango/pango-font.h:380:33: error: ISO C restricts enumerator values to range of 'int' [-Wpedantic]
>>>    PANGO_GLYPH_INVALID_INPUT =   ((PangoGlyph)0xFFFFFFFF),
>>>                                  ^
>>> compilation terminated due to -Wfatal-errors.
>>> make[3]: *** [mssh.o] Error 1
> 
> The code which causes the FTBFS is part of
> /usr/include/pango-1.0/pango/pango-font.h and I'd suspect that this is
> not an mssh-specific issue. (Then OTOH this should have caused quite
> many FTBTS and I've found no according bug report against the pango1.0
> source package. Maybe not much programs use -Wpedantic?)
> 
> Also grepping through the mssh source package code for
> PANGO_GLYPH_INVALID_INPUT or PangoGlyph did not yield any result.
> 
> At least the -Wpedantic comes from mssh:
> 
> src/Makefile.am:AM_CFLAGS = -pedantic-errors -Werror -Wall -Wfatal-errors -Wwrite-strings
> 
> Nevertheless I think that a library should not cause a FTBFS due to
> this compiler flag.
> 
> In case you think, this is still an mssh fault, please explain and
> help me to understand why.

Looks fixed upstream (change reverted):
https://git.gnome.org/browse/pango/commit/pango/pango-font.h?id=8c1a6ef147edceb05921bb892d620bdced277662

Emilio