Bug#906210: gnome-documents: conditional catch clauses are incompatible with mozjs60 (gjs 1.53.90+)

[Simon McVittie]

Package: gnome-documents
Version: 3.28.0-1
Severity: important
Tags: upstream buster sid
Control: block 906016 by -1

gjs 1.53.90+ switches its Javascript implementation from mozjs52 to
mozjs60, a newer Mozilla Spidermonkey release which drops some
Mozilla-proprietary extensions. A gjs maintainer has developed a tool,
<https://gitlab.gnome.org/ptomato/moz60tool>, which can be used to check
for most of the problem cases.

When I ran that tool against gnome-documents I got warnings:

gnome-documents/src/evinceview.js:318:17: Conditional catch clause used.
  WRONG:   catch (e if e.code === 23) {...}
  CORRECT: catch (e) { if (e.code === 23) {...} }

gnome-documents/src/places.js:63:17: Conditional catch clause used.
  WRONG:   catch (e if e.code === 23) {...}
  CORRECT: catch (e) { if (e.code === 23) {...} }

This has probably been fixed upstream for GNOME 3.30. The GNOME team is
in the process of uploading GNOME 3.30 libraries to experimental.

gjs will need to have a Breaks against unfixed gnome-documents versions.

Regards,
    smcv

-- System Information:
Debian Release: buster/sid
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.17.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages gnome-documents depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.28.0-2
ii  gir1.2-evince-3.0                            3.28.2-1
ii  gir1.2-gdata-0.0                             0.17.9-2
ii  gir1.2-gdkpixbuf-2.0                         2.36.12-1
ii  gir1.2-gepub-0.6                             0.6.0-1
ii  gir1.2-gnomedesktop-3.0                      3.28.2-2
ii  gir1.2-goa-1.0                               3.28.0-1
ii  gir1.2-gtk-3.0                               3.22.30-2
ii  gir1.2-pango-1.0                             1.42.1-2
ii  gir1.2-tracker-2.0                           2.0.3-3
ii  gir1.2-webkit2-4.0                           2.20.5-1
ii  gir1.2-zpj-0.0                               0.0.3-4
ii  gjs                                          1.52.3-2
ii  gnome-online-miners                          3.26.0-3
ii  libc6                                        2.27-5
ii  libcairo-gobject2                            1.15.10-3
ii  libcairo2                                    1.15.10-3
ii  libevdocument3-4                             3.28.2-1
ii  libevview3-3                                 3.28.2-1
ii  libgdk-pixbuf2.0-0                           2.36.12-1
ii  libglib2.0-0                                 2.57.2-1
ii  libgnome-desktop-3-17                        3.28.2-2
ii  libgtk-3-0                                   3.22.30-2
ii  libpango-1.0-0                               1.42.1-2
ii  libpangocairo-1.0-0                          1.42.1-2
ii  tracker                                      2.0.3-3

Versions of packages gnome-documents recommends:
ii  gir1.2-lokdocview-0.1  1:6.1.0-1
ii  gnome-user-docs        3.28.2-1
ii  libgsf-bin             1.14.43-1
ii  unoconv                0.7-1.1

gnome-documents suggests no packages.

-- no debconf information