<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
Package: libgtksourceview-3.0-1
<br>
Version: 3.22.2-1
<br>
Severity: normal
<br>
Tags: patch
<br>
<br>
--- Please enter the report below this line. ---
<br>
<br>
The official documentation for the "query-tooltip-markup" and the
"query-tooltip-text" signal, says, that the user should free the
returned string with g_free() when done:<br>
<a class="moz-txt-link-freetext" href="https://developer.gnome.org/gtksourceview/stable/GtkSourceMarkAttributes.html#GtkSourceMarkAttributes-query-tooltip-text">https://developer.gnome.org/gtksourceview/stable/GtkSourceMarkAttributes.html#GtkSourceMarkAttributes-query-tooltip-text</a><br>
<br>
However libgtksourceview as well calls "g_free(text)" on the string,
after evoking the callback-method ( See
gtksourcegutterrenderermarks.c, line 313 )<br>
<br>
So whenever the user tries to free the string again, a double-free
seg-fault will happen. Here as well my Stack Overflow question which
describes the problem in detail:<br>
<a class="moz-txt-link-freetext" href="https://stackoverflow.com/questions/42805994/gtksourceview-usage-of-query-tooltip-text">https://stackoverflow.com/questions/42805994/gtksourceview-usage-of-query-tooltip-text</a><br>
<br>
By checking the source-code of libgtksourceview, it looks like the
doc was copy+pasted from the caller-method "<span class="pl-en">gtk_source_mark_attributes_get_tooltip_text</span>
". For this method the doc is actually very correct.<br>
<br>
Attached a patch to fix the doc for both signals.<br>
<br>
Cheers,<br>
Alex<br>
<br>
--- System information. ---
<br>
Architecture: <br>
Kernel: Linux 4.8.0-2-amd64
<br>
<br>
Debian Release: 9.0
<br>
500 testing <a class="moz-txt-link-abbreviated" href="http://www.deb-multimedia.org">www.deb-multimedia.org</a> <br>
500 testing <a class="moz-txt-link-abbreviated" href="ftp://ftp.de.debian.org">ftp.de.debian.org</a> <br>
<br>
--- Package information. ---
<br>
Depends (Version) | Installed
<br>
=============================================-+-==============
<br>
libatk1.0-0 (>= 1.32) | 2.22.0-1
<br>
libc6 (>= 2.14) | <br>
libcairo2 (>= 1.4.10) | <br>
libgdk-pixbuf2.0-0 (>= 2.22.0) | <br>
libglib2.0-0 (>= 2.47.1) | <br>
libgtk-3-0 (>= 3.19.12) | <br>
libpango-1.0-0 (>= 1.18.0) | <br>
libpangocairo-1.0-0 (>= 1.14.0) | <br>
libxml2 (>= 2.7.4) | <br>
libgtksourceview-3.0-common (>= 3.22.2-1) | <br>
<br>
<br>
Package's Recommends field is empty.
<br>
<br>
Package's Suggests field is empty.
</body>
</html>