[Debian GNUstep maintainers] Bug#633557: lusernet.app: use modern GNU Objective-C API

Colin Watson cjwatson at ubuntu.com
Mon Jul 11 14:46:07 UTC 2011


Package: lusernet.app
Version: 0.4.2-6
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch oneiric

The following patch converts lusernet.app to the modern GNU Objective-C
API.  Without this, when built with GCC 4.6 we get this compiler
warning:

  Function `objc_lookup_class' implicitly converted to pointer at MsgDB.m:345

... which causes particular problems on certain architectures where
pointers are larger than integers.

This patch is on top of the patch I just sent to fix a build failure
with 'ld --as-needed'; if for some reason you want to apply them in a
different order, it's of course trivial to adjust.

+  * debian/patches/40_modern_objc_api.dpatch: Use the modern GNU Objective-C
+    API.

diff -u lusernet.app-0.4.2/debian/patches/00list lusernet.app-0.4.2/debian/patches/00list
--- lusernet.app-0.4.2/debian/patches/00list
+++ lusernet.app-0.4.2/debian/patches/00list
@@ -5,0 +6,1 @@
+40_modern_objc_api
only in patch2:
unchanged:
--- lusernet.app-0.4.2.orig/debian/patches/40_modern_objc_api.dpatch
+++ lusernet.app-0.4.2/debian/patches/40_modern_objc_api.dpatch
@@ -0,0 +1,19 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 40_modern_objc_api.dpatch by Colin Watson <cjwatson at ubuntu.com>
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: Use the modern GNU Objective-C API.
+
+ at DPATCH@
+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' '--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' lusernet.app~/MsgDB.m lusernet.app/MsgDB.m
+--- lusernet.app~/MsgDB.m	2011-07-11 15:26:52.000000000 +0100
++++ lusernet.app/MsgDB.m	2011-07-11 15:27:04.000000000 +0100
+@@ -342,7 +342,7 @@
+ 
+ //			fprintf(stderr,"got '%s' type '%s'\n",buf,[self msg_getMetaHeader: "Type" : mid]);
+ 
+-			c=objc_lookup_class([self msg_getMetaHeader: "Type" : mid]);
++			c=objc_lookUpClass([self msg_getMetaHeader: "Type" : mid]);
+ 			n=[[NSNumber alloc] initWithInt: i];
+ 			src=[[c alloc] initWithMsg: mid db: self];
+ 			[sources setObject: src forKey: n];

Thanks,

-- 
Colin Watson                                       [cjwatson at ubuntu.com]





More information about the pkg-GNUstep-maintainers mailing list