patches/15_tasn1inpc.diff

[Simon Josefsson]

Is the patches/15_tasn1inpc.diff patch really needed?  It does:

-Libs.private: @LIBGNUTLS_EXTRA_LIBS@
+Libs.private: @LIBGNUTLS_EXTRA_LIBS@ @LTLIBTASN1@

On gnutls-extra.pc.in.

However the gnutls-extra.pc.in also requires gnutls:

 Requires: gnutls

Which already contains this line:

Libs.private: @LIBGNUTLS_LIBS@ @LTLIBTASN1@

So, wouldn't @LTLIBTASN1@ be added anyway?

To test this, I presume this command should be used?

jas at mocca:~$ pkg-config --libs --static gnutls-extra
-R/usr/local/lib -L/usr/local/lib -lgnutls-extra -lgnutls -ltasn1  
jas at mocca:~$ 

The above seems to produce the correct line, and uses my local
pkg-config files:

jas at mocca:~$ strace pkg-config --libs --static gnutls-extra 2>&1|grep ^open|grep \\.pc
open("/usr/local/lib/pkgconfig/gnutls-extra.pc", O_RDONLY) = 3
open("/usr/local/lib/pkgconfig/gnutls.pc", O_RDONLY) = 4
jas at mocca:~$ cat 

The files contain:

jas at mocca:~$ tail -7 /usr/local/lib/pkgconfig/gnutls.pc 
Name: GnuTLS
Description: Transport Security Layer implementation for the GNU system
URL: http://www.gnu.org/software/gnutls/
Version: 2.8.1
Libs: -L${libdir} -lgnutls
Libs.private: -L${exec_prefix}/lib -lgnutls  -L/usr/local/lib -ltasn1 -R/usr/local/lib
Cflags: -I${includedir}
jas at mocca:~$ tail -8 /usr/local/lib/pkgconfig/gnutls-extra.pc 
Name: GnuTLS-extra
Description: Additional add-ons for GnuTLS licensed under GPL
URL: http://www.gnu.org/software/gnutls/
Requires: gnutls
Version: 2.8.1
Libs: -L${libdir} -lgnutls-extra
Libs.private: -L${exec_prefix}/lib -lgnutls-extra  
Cflags: -I${includedir}
jas at mocca:~$ 

If I move away my local files, the output is essentially the same,
probably because pkg-config removes duplicates:

jas at mocca:~$ pkg-config --libs --static gnutls-extra
-lgnutls-extra -lgnutls -ltasn1  
jas at mocca:~$ strace pkg-config --libs --static gnutls-extra 2>&1|grep ^open|grep \\.pc
open("/usr/lib/pkgconfig/gnutls-extra.pc", O_RDONLY) = 3
open("/usr/lib/pkgconfig/gnutls.pc", O_RDONLY) = 4
jas at mocca:~$ 

This is with gnutls 2.7.14-1 installed. So it seems the patch doesn't
really do anything?

/Simon