Bug#554343: libtasn1-3: don't run tests when cross-compiling

[Simon Josefsson]

Colin Watson <cjwatson at ubuntu.com> writes:

> Package: libtasn1-3
> Version: 2.2-1
> Severity: normal
> Tags: patch
> User: ubuntu-devel at lists.ubuntu.com
> Usertags: origin-ubuntu ubuntu-patch karmic
>
> Running tests when cross-compiling doesn't work

Is that something that should be supported by debian packages?  I
believe many packages will have the some problem, so potentially there
is a better way to deal with it than patching each and every package.
If debian packages doesn't have to support cross-compilation per the
debian packaging policy, maybe patching packages isn't the right
solution.

Also, it seems to me that the patch isn't generally the right thing,
there are plenty of cross-compilation targets where you _can_ run the
binary on the host architecture (i686 on amd64, windows via wine, etc).

I suspect we may just commit your patch because it isn't much work, but
I wanted to raise these concerns nonetheless.

/Simon

> here, since it requires executing binaries for the host
> architecture. This patch disables tests in this case.
>
>   * Don't run tests when cross-compiling.

> diff -u libtasn1-3-2.2/debian/rules libtasn1-3-2.2/debian/rules
> --- libtasn1-3-2.2/debian/rules
> +++ libtasn1-3-2.2/debian/rules
> @@ -8,7 +8,9 @@
>  include /usr/share/cdbs/1/rules/simple-patchsys.mk
>  
>  DEB_CONFIGURE_EXTRA_FLAGS = --enable-ld-version-script
> +ifeq ($(DEB_BUILD_GNU_TYPE),$(DEB_HOST_GNU_TYPE))
>  DEB_MAKE_CHECK_TARGET = check
> +endif
>  DEB_DH_STRIP_ARGS = --dbg-package libtasn1-3-dbg
>  DEB_DH_INSTALL_SOURCEDIR = debian/tmp
>  DEB_DH_MAKESHLIBS_ARGS_ALL := -V 'libtasn1-3 (>=1.6-0)'
>
> Thanks,