[pkg-go] Bug#835057: golang-fsnotify: FTBFS too much often (failing tests)

[Santiago Vila]

Package: src:golang-fsnotify
Version: 1.3.0-3
Severity: serious

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
(which is what the "Arch: all" autobuilder would do to build it)
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=golang --with=golang
   dh_testdir -i -O--buildsystem=golang
   dh_update_autotools_config -i -O--buildsystem=golang
   dh_auto_configure -i -O--buildsystem=golang
   dh_auto_build -i -O--buildsystem=golang
	go install -v -p 1 github.com/fsnotify/fsnotify
golang.org/x/sys/unix
github.com/fsnotify/fsnotify
   dh_auto_test -i -O--buildsystem=golang
	go test -v -p 1 github.com/fsnotify/fsnotify
=== RUN   TestPollerWithBadFd
--- PASS: TestPollerWithBadFd (0.00s)

[... snipped ...]

	integration_test.go:602: event received: "/tmp/fsnotify922962472/TestFsnotifyEvents.testfile": RENAME
	integration_test.go:602: event received: "/tmp/fsnotify922962472/TestFsnotifyEvents.testfileRenamed": CREATE
	integration_test.go:602: event received: "/tmp/fsnotify922962472/TestFsnotifyEvents.testfile": RENAME
	integration_test.go:637: calling Close()
	integration_test.go:639: waiting for the event channel to become closed...
	integration_test.go:642: event channel closed
=== RUN   TestFsnotifyRenameToCreate
--- PASS: TestFsnotifyRenameToCreate (0.50s)
	integration_test.go:684: event received: "/tmp/fsnotify040233319/TestFsnotifyEvents.testfileRenamed": CREATE
	integration_test.go:713: calling Close()
	integration_test.go:715: waiting for the event channel to become closed...
	integration_test.go:718: event channel closed
=== RUN   TestFsnotifyRenameToOverwrite
--- PASS: TestFsnotifyRenameToOverwrite (0.50s)
	integration_test.go:772: event received: "/tmp/fsnotify422569009/TestFsnotifyEvents.testfileRenamed": CREATE
	integration_test.go:801: calling Close()
	integration_test.go:803: waiting for the event channel to become closed...
	integration_test.go:806: event channel closed
=== RUN   TestRemovalOfWatch
--- PASS: TestRemovalOfWatch (0.60s)
	integration_test.go:844: No event received, as expected.
=== RUN   TestFsnotifyAttrib
--- PASS: TestFsnotifyAttrib (1.50s)
	integration_test.go:901: event received: "/tmp/fsnotify018300782/TestFsnotifyAttrib.testfile": CHMOD
	integration_test.go:901: event received: "/tmp/fsnotify018300782/TestFsnotifyAttrib.testfile": WRITE
	integration_test.go:901: event received: "/tmp/fsnotify018300782/TestFsnotifyAttrib.testfile": CHMOD
	integration_test.go:979: calling Close()
	integration_test.go:981: waiting for the event channel to become closed...
	integration_test.go:984: event channel closed
=== RUN   TestFsnotifyClose
--- PASS: TestFsnotifyClose (0.05s)
=== RUN   TestFsnotifyFakeSymlink
--- PASS: TestFsnotifyFakeSymlink (0.50s)
	integration_test.go:1053: Created bogus symlink
	integration_test.go:1039: event received: "/tmp/fsnotify282172112/zzznew": CREATE
	integration_test.go:1075: calling Close()
=== RUN   TestCyclicSymlink
--- PASS: TestCyclicSymlink (0.50s)
=== RUN   TestConcurrentRemovalOfWatch
--- SKIP: TestConcurrentRemovalOfWatch (0.00s)
	integration_test.go:1131: regression test for race only present on darwin
=== RUN   TestClose
--- PASS: TestClose (0.00s)
=== RUN   TestRemoveWithClose
--- PASS: TestRemoveWithClose (0.01s)
FAIL
exit status 1
FAIL	github.com/fsnotify/fsnotify	13.464s
dh_auto_test: go test -v -p 1 github.com/fsnotify/fsnotify returned exit code 1
debian/rules:4: recipe for target 'build-indep' failed
make: *** [build-indep] Error 1
dpkg-buildpackage: error: debian/rules build-indep gave error exit status 2
--------------------------------------------------------------------------------

Because this source package only generates "Arch: all" packages, this
is the same as a FTBFS bug in the usual sense, and the fact that I was
doing "dpkg-buildpackage -A" does not mean anything special.

I attach three different build logs, but you can find more failed
build logs here:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/golang-fsnotify.html

Once you make this to build reliably again, please consider uploading
the package in source-only form, so that we get pretty official build
logs here:

https://buildd.debian.org/status/package.php?p=golang-fsnotify

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: golang-fsnotify_1.3.0-3_amd64-20160810T2339Z.gz
Type: application/gzip
Size: 5671 bytes
Desc: 
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20160821/3ebb56be/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: golang-fsnotify_1.3.0-3_amd64-20160818T193101Z.gz
Type: application/gzip
Size: 5627 bytes
Desc: 
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20160821/3ebb56be/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: golang-fsnotify_1.3.0-3_amd64-20160819T104418Z.gz
Type: application/gzip
Size: 5598 bytes
Desc: 
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20160821/3ebb56be/attachment-0005.bin>