<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Dear pkg-go maintainers,<br>
<br>
I bumped into a trouble while packaging
<a class="moz-txt-link-rfc2396E" href="https://github.com/containerd/typeurl"><https://github.com/containerd/typeurl></a>.<br>
<br>
The library is fairly simple, however the file marshal_test.go [1]
contains this line:<br>
<br>
eventsapi <span class="pl-s"><span class="pl-pds">"</span>github.com/containerd/containerd/api/services/events/v1<span
class="pl-pds">"<br>
<br>
This is a circulare dependency, since containerd/typeurl is a
depency of of containerd/containerd, but requires
containerd/containerd for this test.<br>
<br>
This breaks dh-make-golang with this error:<br>
<br>
2018/02/13 18:29:20 Downloading
"github.com/containerd/typeurl/..."<br>
go get: 82.03 MiBpackage github.com/containerd/typeurl<br>
imports github.com/containerd/containerd/typeurl: cannot
find package "github.com/containerd/containerd/typeurl" in any
of:<br>
/usr/lib/go-1.7/src/github.com/containerd/containerd/typeurl
(from $GOROOT)<br>
/tmp/dh-make-golang738896973/src/github.com/containerd/containerd/typeurl
(from $GOPATH)<br>
2018/02/13 18:29:44 Could not create a tarball of the upstream
source: exit status 1<br>
<br>
The fact that it breaks dh-make-dolang is not the blocker here,
as I can workaround and create the packaging files manually.
However, what should I do with this `marshal_test.go` file ?
Should I exclude it from the package ? Or should I patch it ?<br>
<br>
And more generally: I've noticed that a lot of go packages have
test files named `*_test.go` Is it good policy to remove them
from the package when they get in the way like this ? Or are
they needed in some way that I don't expect ?<br>
<br>
</span></span>Thanks,<br>
<br>
Arnaud<br>
<br>
[1]:
<a class="moz-txt-link-freetext" href="https://github.com/containerd/typeurl/blob/master/marshal_test.go">https://github.com/containerd/typeurl/blob/master/marshal_test.go</a><br>
<br>
</body>
</html>