<div dir="ltr">Hey,<div><br></div><div>I did a quick rebuild of our packages with Go 1.10 (I plan to write in more detail about the infrastructure I used in the next few days) and noticed the following new failures:</div><div><br></div><div><div>no longer compiles: <a href="http://github.com/gopherjs/gopherjs">github.com/gopherjs/gopherjs</a>. error exit status 2</div><div>no longer passes tests: <a href="http://github.com/julienschmidt/httprouter">github.com/julienschmidt/httprouter</a>. error exit status 1</div><div>no longer <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">passes<span> </span></span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">tests</span>: <a href="http://github.com/masterzen/winrm">github.com/masterzen/winrm</a>. error exit status 1</div><div>no longer <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">passes<span> </span></span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">tests</span>: <a href="http://golang.org/x/oauth2">golang.org/x/oauth2</a>. error exit status 1</div><div>no longer <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">passes<span> </span></span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">tests</span>: <a href="http://gopkg.in/macaroon-bakery.v2">gopkg.in/macaroon-bakery.v2</a>. error exit status 1</div><div>no longer <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">passes<span> </span></span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">tests</span>: <a href="http://gopkg.in/tylerb/graceful.v1">gopkg.in/tylerb/graceful.v1</a>. error exit status 1</div></div><div><br></div><div>Caveat: there may be others which were broken before for unrelated reasons, but this list seems like a good start.</div><div><br></div><div>If anyone would like to help with proactively fixing these issues, that’d be appreciated! I expect that most often, importing a new upstream version entirely, or cherry-picking an upstream commit would be all that’s necessary.</div><div><br></div><div>Thanks in advance!</div><div><br></div><div>Here are the full error logs:</div><div><br></div><div><div><a href="http://github.com/gopherjs/gopherjs">github.com/gopherjs/gopherjs</a>. error exit status 2</div><div># <a href="http://github.com/gopherjs/gopherjs/compiler">github.com/gopherjs/gopherjs/compiler</a></div><div>/srv/gopath/src/<a href="http://github.com/gopherjs/gopherjs/compiler/compiler.go:20:9">github.com/gopherjs/gopherjs/compiler/compiler.go:20:9</a>: undefined: ___GOPHERJS_REQUIRES_GO_VERSION_1_9___</div><div><br></div><div><div>no longer compiles: <a href="http://github.com/julienschmidt/httprouter">github.com/julienschmidt/httprouter</a>. error exit status 1</div><div>--- FAIL: TestRouterNotFound (0.00s)</div><div> router_test.go:234: NotFound handling route /path/ failed: Code=301, Header=map[Location:[/path] Content-Type:[text/html; charset=utf-8]]</div><div> router_test.go:234: NotFound handling route /dir failed: Code=301, Header=map[Location:[/dir/] Content-Type:[text/html; charset=utf-8]]</div><div> router_test.go:234: NotFound handling route failed: Code=301, Header=map[Location:[/] Content-Type:[text/html; charset=utf-8]]</div><div> router_test.go:234: NotFound handling route /PATH failed: Code=301, Header=map[Location:[/path] Content-Type:[text/html; charset=utf-8]]</div><div> router_test.go:234: NotFound handling route /DIR/ failed: Code=301, Header=map[Location:[/dir/] Content-Type:[text/html; charset=utf-8]]</div><div> router_test.go:234: NotFound handling route /PATH/ failed: Code=301, Header=map[Content-Type:[text/html; charset=utf-8] Location:[/path]]</div><div> router_test.go:234: NotFound handling route /DIR failed: Code=301, Header=map[Location:[/dir/] Content-Type:[text/html; charset=utf-8]]</div><div> router_test.go:234: NotFound handling route /../path failed: Code=301, Header=map[Location:[/path] Content-Type:[text/html; charset=utf-8]]</div><div>FAIL</div><div>FAIL <a href="http://github.com/julienschmidt/httprouter">github.com/julienschmidt/httprouter</a> 0.016s</div></div><div><br></div><div><div><a href="http://github.com/masterzen/winrm">github.com/masterzen/winrm</a>. error exit status 1</div><div><br></div><div>----------------------------------------------------------------------</div><div>FAIL: client_test.go:89: WinRMSuite.TestRunWithString</div><div><br></div><div>client_test.go:100:</div><div> c.Assert(stdout, Equals, "That's all folks!!!")</div><div>... obtained string = "That's all folks!!!\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00"</div><div>... expected string = "That's all folks!!!"</div><div><br></div><div>OOPS: 36 passed, 1 FAILED</div><div>--- FAIL: Test (5.03s)</div><div>FAIL</div><div>FAIL <a href="http://github.com/masterzen/winrm">github.com/masterzen/winrm</a> 5.041s</div></div><div><br></div><div><div><a href="http://golang.org/x/oauth2">golang.org/x/oauth2</a>. error exit status 1</div><div>ok <a href="http://golang.org/x/oauth2">golang.org/x/oauth2</a> (cached)</div><div>? <a href="http://golang.org/x/oauth2/amazon">golang.org/x/oauth2/amazon</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/bitbucket">golang.org/x/oauth2/bitbucket</a> [no test files]</div><div>ok <a href="http://golang.org/x/oauth2/clientcredentials">golang.org/x/oauth2/clientcredentials</a> (cached)</div><div>? <a href="http://golang.org/x/oauth2/facebook">golang.org/x/oauth2/facebook</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/fitbit">golang.org/x/oauth2/fitbit</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/foursquare">golang.org/x/oauth2/foursquare</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/github">golang.org/x/oauth2/github</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/heroku">golang.org/x/oauth2/heroku</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/hipchat">golang.org/x/oauth2/hipchat</a> [no test files]</div><div>--- FAIL: TestRetrieveTokenBustedNoSecret (0.00s)</div><div> token_test.go:42: RetrieveToken = unexpected end of JSON input; want no error</div><div>--- FAIL: TestRetrieveTokenWithContexts (0.00s)</div><div> token_test.go:91: RetrieveToken (with background context) = unexpected end of JSON input; want no error</div><div>FAIL</div><div>FAIL <a href="http://golang.org/x/oauth2/internal">golang.org/x/oauth2/internal</a> 0.004s</div><div>ok <a href="http://golang.org/x/oauth2/jws">golang.org/x/oauth2/jws</a> (cached)</div><div>ok <a href="http://golang.org/x/oauth2/jwt">golang.org/x/oauth2/jwt</a> (cached)</div><div>? <a href="http://golang.org/x/oauth2/linkedin">golang.org/x/oauth2/linkedin</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/mediamath">golang.org/x/oauth2/mediamath</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/microsoft">golang.org/x/oauth2/microsoft</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/odnoklassniki">golang.org/x/oauth2/odnoklassniki</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/paypal">golang.org/x/oauth2/paypal</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/slack">golang.org/x/oauth2/slack</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/uber">golang.org/x/oauth2/uber</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/vk">golang.org/x/oauth2/vk</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/yandex">golang.org/x/oauth2/yandex</a> [no test files]</div></div><div><br></div><div><div><a href="http://gopkg.in/macaroon-bakery.v2">gopkg.in/macaroon-bakery.v2</a>. error exit status 1</div><div>ok <a href="http://gopkg.in/macaroon-bakery.v2/bakery">gopkg.in/macaroon-bakery.v2/bakery</a> (cached)</div><div>ok <a href="http://gopkg.in/macaroon-bakery.v2/bakery/checkers">gopkg.in/macaroon-bakery.v2/bakery/checkers</a> (cached)</div><div>ok <a href="http://gopkg.in/macaroon-bakery.v2/bakery/identchecker">gopkg.in/macaroon-bakery.v2/bakery/identchecker</a> (cached)</div><div>? <a href="http://gopkg.in/macaroon-bakery.v2/bakery/internal/macaroonpb">gopkg.in/macaroon-bakery.v2/bakery/internal/macaroonpb</a> [no test files]</div><div>ok <a href="http://gopkg.in/macaroon-bakery.v2/bakery/mgorootkeystore">gopkg.in/macaroon-bakery.v2/bakery/mgorootkeystore</a> (cached)</div><div>ok <a href="http://gopkg.in/macaroon-bakery.v2/bakerytest">gopkg.in/macaroon-bakery.v2/bakerytest</a> (cached)</div><div><br></div><div>----------------------------------------------------------------------</div><div>FAIL: keyring_test.go:157: KeyringSuite.TestThirdPartyInfoForLocationReturnsStatusInternalServerError</div><div><br></div><div>keyring_test.go:164:</div><div> c.Assert(err, gc.ErrorMatches,</div><div> fmt.Sprintf(`Get %s/discharge/info: cannot unmarshal error response \(status 500 Internal Server Error\): unexpected content type text/plain; want application/json; content: `, ts.URL))</div><div>... error string = "Get <a href="http://127.0.0.1:39547/discharge/info">http://127.0.0.1:39547/discharge/info</a>: cannot unmarshal error response (status 500 Internal Server Error): unexpected content type \"\"; want application/json; content: \"\""</div><div>... regex string = "Get <a href="http://127.0.0.1:39547/discharge/info">http://127.0.0.1:39547/discharge/info</a>: cannot unmarshal error response \\(status 500 Internal Server Error\\): unexpected content type text/plain; want application/json; content: "</div><div><br></div><div>OOPS: 45 passed, 1 FAILED</div><div>--- FAIL: TestPackage (1.95s)</div><div>FAIL</div><div>FAIL <a href="http://gopkg.in/macaroon-bakery.v2/httpbakery">gopkg.in/macaroon-bakery.v2/httpbakery</a> 1.956s</div></div><div><br></div><div><div><a href="http://gopkg.in/tylerb/graceful.v1">gopkg.in/tylerb/graceful.v1</a>. error exit status 1</div><div>2018/02/15 11:02:24 http: TLS handshake error from [::1]:53422: remote error: tls: bad certificate</div><div>--- FAIL: TestHTTP2ListenAndServeTLS (0.10s)</div><div> http2_test.go:48: Error encountered while connecting to test server: Get <a href="https://localhost:9654">https://localhost:9654</a>: tls: failed to parse certificate from server: x509: cannot parse dnsName "Test Intermediate CA"</div><div>2018/02/15 11:02:24 http: TLS handshake error from [::1]:53424: remote error: tls: bad certificate</div><div>--- FAIL: TestHTTP2ListenAndServeTLSConfig (0.10s)</div><div> http2_test.go:48: Error encountered while connecting to test server: Get <a href="https://localhost:9654">https://localhost:9654</a>: tls: failed to parse certificate from server: x509: cannot parse dnsName "Test Intermediate CA"</div><div>FAIL</div><div>FAIL <a href="http://gopkg.in/tylerb/graceful.v1">gopkg.in/tylerb/graceful.v1</a> 4.668s</div></div><div><br></div><div><br></div>-- <br><div class="gmail_signature">Best regards,<br>Michael</div>
</div></div>