<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<tt>In Between.</tt><tt><br>
</tt><tt><br>
</tt><tt><br>
</tt>
<div class="moz-cite-prefix"><tt>On 04/09/2018 12:14 PM, Michael
Stapelberg wrote:</tt><tt><br>
</tt></div>
<blockquote type="cite"
cite="mid:CANnVG6=W=rkazF3E0ccnyFE0CFAELRhpzt73Z3AaYtO=DxD3yw@mail.gmail.com">
<div dir="ltr"><tt>The package looks good, but it might be good to
remove the NOTE in the Expat License entry in
debian/copyright:</tt></div>
</blockquote>
<tt>Thanks a lot for taking out the time to review the pa</tt><tt>ckages.</tt><tt><br>
</tt>
<blockquote type="cite"
cite="mid:CANnVG6=W=rkazF3E0ccnyFE0CFAELRhpzt73Z3AaYtO=DxD3yw@mail.gmail.com">
<div dir="ltr">
<div><tt><br>
</tt></div>
<div>
<div><tt> NOTE: Various optional and subordinate components
carry their own licensing</tt></div>
<div><tt> requirements and restrictions. Use of those
components is subject to the terms</tt></div>
<div><tt> and conditions outlined the respective license of
each component.</tt></div>
</div>
<div><tt><br>
</tt></div>
<div><tt>I’m suggesting to remove it because we don’t vendor in
Debian, so this doesn’t apply. In case I’m misunderstanding
what components the note refers to, and it means parts of
the source itself, not just vendored dependencies, that
would be even more reason to remove it, because those would
need to be listed explicitly in debian/copyright.</tt></div>
</div>
</blockquote>
<tt>Dropping the note. </tt><tt><br>
</tt>
<blockquote type="cite"
cite="mid:CANnVG6=W=rkazF3E0ccnyFE0CFAELRhpzt73Z3AaYtO=DxD3yw@mail.gmail.com">
<div dir="ltr">
<div><tt><br>
</tt></div>
<div><tt>The copyright statement itself also looked insufficient
to me, but I can’t find a more specific identifier than
“SmartyStreets”. I had hoped to find something like
SmartyStreets Inc. or LLC to convey that this is a company
(as opposed to a GitHub username), but couldn’t find
anything on their website. Let’s hope that ftp-master is
okay with the copyright as-is.</tt></div>
</div>
</blockquote>
<tt>I looked at a few other packages by smartystreets which are
already in Debian main. Including</tt><tt><br>
</tt><tt>goconvey
<a class="moz-txt-link-freetext" href="https://tracker.debian.org/pkg/golang-github-smartystreets-goconvey">https://tracker.debian.org/pkg/golang-github-smartystreets-goconvey</a></tt><tt><br>
</tt><tt>and<br>
assertions
<a class="moz-txt-link-freetext" href="https://tracker.debian.org/pkg/golang-github-smartystreets-assertions">https://tracker.debian.org/pkg/golang-github-smartystreets-assertions</a></tt><tt><br>
</tt><tt><br>
</tt><tt>and both of them seem to refer to smarty streets as
SmartyStreets, LLC</tt><tt><br>
</tt><tt>even the upstream source code license mentions it as
SmartyStreets, LLC</tt><tt><br>
</tt><tt>It is just in my case the upstream license just has the
name as SmartyStreets</tt><tt><br>
</tt><tt><br>
</tt><tt>Should I just keep the name as is in the upstream or should
there be no issues adding the LLC part?</tt><tt><br>
</tt><tt><br>
</tt><tt><br>
</tt>
<blockquote type="cite"
cite="mid:CANnVG6=W=rkazF3E0ccnyFE0CFAELRhpzt73Z3AaYtO=DxD3yw@mail.gmail.com">
<div class="gmail_extra"><tt><br>
</tt>
<div class="gmail_quote"><tt>On Sun, Apr 8, 2018 at 11:11 AM, </tt><tt><span
dir="ltr"><<a href="mailto:rajudev@disroot.org"
target="_blank" moz-do-not-send="true">rajudev@disroot.org</a>></span></tt><tt>
wrote:</tt><tt><br>
</tt>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><tt>Hello
Go Team,</tt><tt><br>
</tt><tt>
I have prepared the packaging for </tt><tt><a
href="https://github.com/smartystreets/gunit"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://github.com/<wbr>smartystreets/gunit</a></tt><tt><br>
</tt><tt>
and have uploaded to Salsa.</tt><tt><br>
</tt><tt>
Please take a look at the package, review and upload it.</tt><tt><br>
</tt>
<tt><br>
</tt>
<tt><a
href="https://salsa.debian.org/go-team/packages/golang-github-smartystreets-gunit"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://salsa.debian.org/go-<wbr>team/packages/golang-github-<wbr>smartystreets-gunit</a></tt><tt><br>
</tt>
<tt><br>
</tt><tt>
Usually I send RFS mails to pkg-go list, should I also
start CCing debian-devel list?</tt><tt><br>
</tt>
<tt><br>
</tt><tt>
Thanks,</tt><tt><br>
</tt><tt>
Raju Devidas</tt><tt><br>
</tt>
<tt><br>
</tt><tt>
______________________________</tt><wbr><tt>_________________</tt><tt><br>
</tt><tt>
Pkg-go-maintainers mailing list</tt><tt><br>
</tt>
<tt><a
href="mailto:Pkg-go-maintainers@lists.alioth.debian.org"
moz-do-not-send="true">Pkg-go-maintainers@lists.<wbr>alioth.debian.org</a></tt><tt><br>
</tt>
<tt><a
href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.alioth.debian.<wbr>org/cgi-bin/mailman/listinfo/<wbr>pkg-go-maintainers</a></tt><tt><br>
</tt>
</blockquote>
</div>
<tt><br>
</tt><tt><br clear="all">
</tt>
<div><tt><br>
</tt></div>
<tt>-- </tt><tt><br>
</tt>
<div class="gmail_signature" data-smartmail="gmail_signature"><tt>Best
regards,</tt><tt><br>
</tt><tt>Michael</tt></div>
</div>
</blockquote>
<tt><br>
</tt><tt><br>
</tt><tt>-- <br>
Raju Devidas
<br>
rajudev.gitlab.io
<br>
XMPP/Jabber: rajudev(at)disroot.org
</tt>
</body>
</html>