[DebianGIS-dev] Bug#418833: grass: Init.sh is broken

Hamish hamish_nospam at yahoo.com
Tue Apr 17 03:01:15 UTC 2007


Package: grass
Version: 6.0.2-0.dgis.stable.1
Followup-For: Bug #418833

that patch makes it functional, but still there is a problem?

[this is lib/init/init.sh; bug already fixed by Frankie in DebianGIS's SVN]

http://svn.debian.org/wsvn/pkg-grass/packages/grass/trunk/debian/patches/www-browser.dpatch?op=file&rev=0&sc=0

problem:

+	else 
+  		GRASS_HTML_BROWSER=true

GRASS_HTML_BROWSER should be the path to a web broswer executable, not a boolean
answer. UNLESS we just want it to silently fail by setting the web browser to be
`/bin/true`, but that's a bit odd and misleading to readers of the script.

FWIW I've cleaned up this part of lib/init/init.sh in the GRASS CVS some weeks ago:
http://freegis.org/cgi-bin/viewcvs.cgi/grass6/lib/init/init.sh
  Revision 1.106


suggest changing the `true` fallback to something more web browserish.
("mozilla not found" is a better error message than "true not found")


Hamish




More information about the Pkg-grass-devel mailing list