ossim-1.8.16 - request for review

[Markus Wanner]

Bas,

On 01/30/2014 12:17 AM, Sebastiaan Couwenberg wrote:
> You're a member of the pkg-grass team, and you should therefor have
> commit access to both the Git and SVN repos.

Okay, cool.

> Most of the Debian GIS packages are maintain in Git now, OSSIM is one
> of the few remaining package still in SVN.
> 
> Would you be willing to move the OSSIM package from SVN to Git?

Yeah, why not...

>> Please review and comment whether or not you agree with the
>> general direction.
> 
> If I may propose a wishlist item, move from CDBS to dh for more
> uniformity with the other Debian GIS packages.

Ehm... the patch already does that. It's one of the "general direction"
questions I'm unsure about. But if you guys happen to like dh better as
well, it's all fine.

> It's probably sufficient to add CPPFLAGS to CFLAGS in debian/rules to
> have the build use -D_FORTIFY_SOURCE=2, which I assume is the
> hardening issue lintian reports.

Oh, yeah, CPPFLAGS somehow got lost. My bad. Initializing CPPFLAGS from
dpkg-buildflags works. Thanks for the hint.

> It's a good thing it builds, nice work!

Thanks

Markus

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1574 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-grass-devel/attachments/20140130/4a5c3b76/attachment.sig>