Bug#834174: Removal of -Werror=security in GDAL rules is useless

[Sebastiaan Couwenberg]

Control: tags -1 pending

Hi Even,

Thanks for reporting this issue.

On 08/12/2016 08:13 PM, Even Rouault wrote:
> The debian/rules file contains the following lines  :
> """
> # Remove -Werror=format-security, causes build failure on ogrsxfdatasource.cpp
> CFLAGS   = $(shell dpkg-buildflags --get CFLAGS)
> CXXFLAGS = $(shell dpkg-buildflags --get CXXFLAGS)
> 
> CFLAGS   := $(filter-out -Werror=format-security, $(CFLAGS))
> CXXFLAGS := $(filter-out -Werror=format-security, $(CXXFLAGS))
> """
> 
> They are probably unneeded since GDAL 2.1.0

I've removed buildflags changes, and the build now indeed doesn't fail
any more. Thanks for fixing that upstream!

Due to the recent GCC 6/ICU 57/Boost 1.61 transitions there are large
number of changed C++ symbols which break the ABI. I am therefore
hesitant to upload a new GDAL revision now, I don't want any segfaulting
reverse dependencies because of undefined references to the old (now
missing) symbols. The change for the above is committed in git, and will
be included in the next upload. That will be for GDAL 2.1.2 or if GDAL
is rebuilt for another transition and the reverse dependencies are not
adversely affected or if they are and we do another transition for GDAL.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1