Bug#836685: qlandkartegt: [PATCH] Fix build error on archs where char is unsigned by default

Christoph Biedl debian.axhn at manchmal.in-ulm.de
Sun Sep 4 16:57:22 UTC 2016


Package: qlandkartegt
Version: 1.8.1+ds-6+b3
Severity: important
Tags: patch

Dear Maintainer,

as you've certainly learned too, qlandkartegt 1.8.1+ds-6+b3 fails to
build on several architectures due to -Wnarrowing in recent gcc
versions. It seems however forcing signed characters makes the build
pass again, and the resulting package works as expected. Tested on
powerpc in the stretch distribution:

--- a/debian/rules
+++ b/debian/rules
@@ -2,6 +2,8 @@
 
 # Enable hardening build flags
 export DEB_BUILD_MAINT_OPTIONS=hardening=+all
+CXXFLAGS += -fsigned-char
+CFLAGS += -fsigned-char
 
 BUILD_DATE=$(shell dpkg-parsechangelog | sed -ne 's/^Date: //p' | LC_ALL=C date -u "+%d %B %Y" -f -)
 
It might be sufficient to enhance CXXFLAGS only but given a build time
of more than three hours you'll forgive me for not testing this in
detail.

Besides, "overrid_dh_clean" in debian/rules should probably be
"override_dh_clean"

Regards,

    Christoph

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: powerpc (ppc)

Kernel: Linux 4.4.19
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages qlandkartegt depends on:
ii  libc6                       2.23-4
ii  libdmtx0a                   0.7.4-2
ii  libexif12                   0.6.21-2
ii  libgcc1                     1:6.1.1-11
ii  libgdal20 [gdal-abi-2-1-1]  2.1.1+dfsg-1+b1
ii  libgl1-mesa-glx [libgl1]    11.2.2-1
ii  libglu1-mesa [libglu1]      9.0.0-2.1
ii  libgps22                    3.16-2
ii  libjpeg62-turbo             1:1.5.0-1
ii  libproj9                    4.9.2-3
ii  libqt5core5a                5.6.1+dfsg-3+b1
ii  libqt5dbus5                 5.6.1+dfsg-3+b1
ii  libqt5gui5                  5.6.1+dfsg-3+b1
ii  libqt5multimedia5           5.6.1-2
ii  libqt5network5              5.6.1+dfsg-3+b1
ii  libqt5opengl5               5.6.1+dfsg-3+b1
ii  libqt5printsupport5         5.6.1+dfsg-3+b1
ii  libqt5qml5                  5.6.1-5
ii  libqt5quick5                5.6.1-5
ii  libqt5script5               5.6.1+dfsg-2
ii  libqt5serialport5           5.6.1-2
ii  libqt5sql5                  5.6.1+dfsg-3+b1
ii  libqt5webkit5               5.6.1+dfsg-5
ii  libqt5widgets5              5.6.1+dfsg-3+b1
ii  libqt5xml5                  5.6.1+dfsg-3+b1
ii  libstdc++6                  6.1.1-11
ii  zlib1g                      1:1.2.8.dfsg-2+b1

Versions of packages qlandkartegt recommends:
pn  gdal-bin  <none>
pn  gpsbabel  <none>

Versions of packages qlandkartegt suggests:
pn  gpsd  <none>

-- no debconf information

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-grass-devel/attachments/20160904/7bcfc2c6/attachment.sig>


More information about the Pkg-grass-devel mailing list