Bug#1049025: ogdi-dfsg: Fails to build source after successful build

[Lucas Nussbaum]

Source: ogdi-dfsg
Version: 4.1.0+ds-6
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ----------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package ogdi-dfsg
> dpkg-buildpackage: info: source version 4.1.0+ds-6
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Bas Couwenberg <sebastic at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> if [ -e config/common.mak ]; then \
> 	dh_auto_clean ; \
> fi
> 	make -j8 clean
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> make[3]: Entering directory '/<<PKGBUILDDIR>>/vpflib'
> rm -rf OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/static/libvpf.* OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/libvpf.* /<<PKGBUILDDIR>>/bin/Linux/libvpf.* /<<PKGBUILDDIR>>/bin/Linux/vpf
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/vpflib'
> make[3]: Entering directory '/<<PKGBUILDDIR>>/ogdi'
> make[4]: Entering directory '/<<PKGBUILDDIR>>/ogdi/include'
> Nothing to clean in ogdi/include
> make[4]: Leaving directory '/<<PKGBUILDDIR>>/ogdi/include'
> make[4]: Entering directory '/<<PKGBUILDDIR>>/ogdi/c-api'
> rm -rf OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/static/libogdi.* OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/libogdi.* /<<PKGBUILDDIR>>/bin/Linux/libogdi.* /<<PKGBUILDDIR>>/bin/Linux/ogdi
> make[4]: Leaving directory '/<<PKGBUILDDIR>>/ogdi/c-api'
> make[4]: Entering directory '/<<PKGBUILDDIR>>/ogdi/glutil'
> rm -rf OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/static/libglutil.* OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/libglutil.* /<<PKGBUILDDIR>>/bin/Linux/libglutil.* /<<PKGBUILDDIR>>/bin/Linux/glutil
> make[4]: Leaving directory '/<<PKGBUILDDIR>>/ogdi/glutil'
> make[4]: Entering directory '/<<PKGBUILDDIR>>/ogdi/attr_driver'
> make[4]: Leaving directory '/<<PKGBUILDDIR>>/ogdi/attr_driver'
> make[4]: Entering directory '/<<PKGBUILDDIR>>/ogdi/driver'
> make[5]: Entering directory '/<<PKGBUILDDIR>>/ogdi/driver/adrg'
> rm -rf OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/static/libadrg.* OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/libadrg.* /<<PKGBUILDDIR>>/bin/Linux/libadrg.* /<<PKGBUILDDIR>>/bin/Linux/adrg
> make[5]: Leaving directory '/<<PKGBUILDDIR>>/ogdi/driver/adrg'
> make[5]: Entering directory '/<<PKGBUILDDIR>>/ogdi/driver/network'
> rm -rf OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/static/libremote.* OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/libremote.* /<<PKGBUILDDIR>>/bin/Linux/libremote.* /<<PKGBUILDDIR>>/bin/Linux/remote
> make[5]: Leaving directory '/<<PKGBUILDDIR>>/ogdi/driver/network'
> make[5]: Entering directory '/<<PKGBUILDDIR>>/ogdi/driver/rpf'
> rm -rf OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/static/librpf.* OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/librpf.* /<<PKGBUILDDIR>>/bin/Linux/librpf.* /<<PKGBUILDDIR>>/bin/Linux/rpf
> make[5]: Leaving directory '/<<PKGBUILDDIR>>/ogdi/driver/rpf'
> make[5]: Entering directory '/<<PKGBUILDDIR>>/ogdi/driver/vrf'
> rm -rf OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/static/libvrf.* OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/libvrf.* /<<PKGBUILDDIR>>/bin/Linux/libvrf.* /<<PKGBUILDDIR>>/bin/Linux/vrf
> make[5]: Leaving directory '/<<PKGBUILDDIR>>/ogdi/driver/vrf'
> make[5]: Entering directory '/<<PKGBUILDDIR>>/ogdi/driver/skeleton'
> rm -rf OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/static/libskeleton.* OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/libskeleton.* /<<PKGBUILDDIR>>/bin/Linux/libskeleton.* /<<PKGBUILDDIR>>/bin/Linux/skeleton
> make[5]: Leaving directory '/<<PKGBUILDDIR>>/ogdi/driver/skeleton'
> make[4]: Leaving directory '/<<PKGBUILDDIR>>/ogdi/driver'
> make[4]: Entering directory '/<<PKGBUILDDIR>>/ogdi/gltpd'
> rm -rf OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/static/libgltpd.* OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/libgltpd.* /<<PKGBUILDDIR>>/bin/Linux/libgltpd.* /<<PKGBUILDDIR>>/bin/Linux/gltpd
> make[4]: Leaving directory '/<<PKGBUILDDIR>>/ogdi/gltpd'
> make[4]: Entering directory '/<<PKGBUILDDIR>>/ogdi/tcl_interface'
> rm -rf OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/static/libecs_tcl.* OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/libecs_tcl.* /<<PKGBUILDDIR>>/bin/Linux/libecs_tcl.* /<<PKGBUILDDIR>>/bin/Linux/ecs_tcl
> make[4]: Leaving directory '/<<PKGBUILDDIR>>/ogdi/tcl_interface'
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/ogdi'
> make[3]: Entering directory '/<<PKGBUILDDIR>>/contrib'
> make[4]: Entering directory '/<<PKGBUILDDIR>>/contrib/ogdi_import'
> rm -rf OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/static/libogdi_import.* OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/libogdi_import.* /<<PKGBUILDDIR>>/bin/Linux/libogdi_import.* /<<PKGBUILDDIR>>/bin/Linux/ogdi_import
> make[4]: Leaving directory '/<<PKGBUILDDIR>>/contrib/ogdi_import'
> make[4]: Entering directory '/<<PKGBUILDDIR>>/contrib/ogdi_info'
> rm -rf OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/static/libogdi_info.* OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/libogdi_info.* /<<PKGBUILDDIR>>/bin/Linux/libogdi_info.* /<<PKGBUILDDIR>>/bin/Linux/ogdi_info
> make[4]: Leaving directory '/<<PKGBUILDDIR>>/contrib/ogdi_info'
> make[4]: Entering directory '/<<PKGBUILDDIR>>/contrib/gdal'
> rm -rf OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/static/libgdal.* OBJ.Linux /<<PKGBUILDDIR>>/lib/Linux/libgdal.* /<<PKGBUILDDIR>>/bin/Linux/libgdal.* /<<PKGBUILDDIR>>/bin/Linux/gdal
> make[4]: Leaving directory '/<<PKGBUILDDIR>>/contrib/gdal'
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/contrib'
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building ogdi-dfsg using existing ./ogdi-dfsg_4.1.0+ds.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of file configure, use --include-removal to override
> dpkg-source: warning: executable mode 0755 of 'config.status' will not be represented in diff
> dpkg-source: warning: executable mode 0755 of 'ogdi-config' will not be represented in diff
> dpkg-source: info: local changes detected, the modified files are:
>  ogdi-dfsg-4.1.0+ds/config.log
>  ogdi-dfsg-4.1.0+ds/config.status
>  ogdi-dfsg-4.1.0+ds/config/Linux.mak
>  ogdi-dfsg-4.1.0+ds/config/common.mak
>  ogdi-dfsg-4.1.0+ds/ogdi-config
>  ogdi-dfsg-4.1.0+ds/ogdi.pc
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/ogdi-dfsg_4.1.0+ds-6.diff.Hi0LNA
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/ogdi-dfsg_4.1.0+ds-6_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.