Bug#260276: grubconf: parses "root=" in menu.lst incorrectly
Luis R. Rodriguez
mcgrof@ruslug.rutgers.edu (Luis R. Rodriguez), 260276@bugs.debian.org
Mon, 19 Jul 2004 20:22:13 -0400
--bAr+fMtvBxbbbkvl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
package grubconf
tags 260276 patch
tags 260276 upstream
thanks
Mika,
this is a bug that should be reported to upstream. I've added
Joseph Monti to the e-mail thread (he's the upstream author). Bellow is my =
attempt
to fix it though. Try this deb and let me know if that fixed it:
http://ruslug.rutgers.edu/~mcgrof/grubconf/grubconf-0.5.1-debian/grubconf_0=
.5.1-4_i386.deb
Monti, can you provide insight or look into this when you get a chance?
There are other patches I've added to the debian package myself. They
can be viewed at:
http://ruslug.rutgers.edu/~mcgrof/grubconf/patches/
Here is the patch I applied:
--- grubconf-0.5.1/src/grubconf_dev.c.orig 2004-07-19 19:45:01.000000000 -0=
400
+++ grubconf-0.5.1/src/grubconf_dev.c 2004-07-19 19:45:39.000000000 -0400
@@ -313,7 +313,8 @@
for (i =3D 0; tmp !=3D NULL && i < dev_size; i++, tmp =3D tmp->next) {
if ( *(tmp->dev_name + 5) =3D=3D *(dev_str + 5) &&
*(tmp->dev_name + 7) =3D=3D *(dev_str + 7) &&=20
- *(tmp->dev_name + 8) =3D=3D *(dev_str + 8) ) {
+ *(tmp->dev_name + 8) =3D=3D *(dev_str + 8) &&
+ *(tmp->dev_name + 9) =3D=3D *(dev_str + 9)) {
return i;
}
}
On Mon, Jul 19, 2004 at 09:12:08PM +0300, Mika Wahlroos wrote:
> Package: grubconf
> Version: 0.5.1-3
> Severity: normal
>=20
> When grubconf is started and reads the grub configuration file, root=3D/d=
ev/hda1x in the=20
> options of the kernel becomes root=3D/dev/hda1 - it drops the latter nume=
ral. For example in=20
> my menu.lst (which was originally generated by grubconf)
>=20
> title Debian GNU/Linux
> #:0 <-- type: 0 =3D> linux, 1 =3D> windows, 2 =3D> other
> root (hd0,7)
> kernel /bzImage root=3D/dev/hda10 (null)
>=20
> becomes
>=20
> title Debian GNU/Linux
> #:0 <-- type: 0 =3D> linux, 1 =3D> windows, 2 =3D> other
> root (hd0,7)
> kernel /bzImage root=3D/dev/hda1 (null)
>=20
> The same happens to another entry where root=3D/dev/hda12 - it also becom=
es
> /dev/hda1.
>=20
> The change appears in the grubconf GUI immediately following grubconf sta=
rtup and sticks=20
> in the configuration file if grubconf rewrites it, i.e. if something is m=
odified with=20
> grubconf.
>=20
> -- System Information:
> Debian Release: testing/unstable
> APT prefers unstable
> APT policy: (500, 'unstable')
> Architecture: i386 (i686)
> Kernel: Linux 2.6.7
> Locale: LANG=3Dfi_FI, LC_CTYPE=3Dfi_FI
>=20
> Versions of packages grubconf depends on:
> ii grub 0.95+cvs20040624-4 GRand Unified Bootloader
> ii libart-2.0-2 2.3.16-5 Library of functions for 2D =
graphi
> ii libatk1.0-0 1.6.1-2 The ATK accessibility toolkit
> ii libaudiofile0 0.2.6-4 Open-source version of SGI's=
audio
> ii libbonobo2-0 2.6.2-4 Bonobo CORBA interfaces libr=
ary
> ii libbonoboui2-0 2.6.1-1 The Bonobo UI library
> ii libc6 2.3.2.ds1-13 GNU C Library: Shared librar=
ies an
> ii libesd0 0.2.29-1 Enlightened Sound Daemon - S=
hared=20
> ii libgconf2-4 2.6.2-1 GNOME configuration database=
syste
> ii libgcrypt7 1.1.90-9 LGPL Crypto library - runtim=
e libr
> ii libglib2.0-0 2.4.4-1 The GLib library of C routin=
es
> ii libgnome-keyring0 0.2.1-2 GNOME keyring services libra=
ry
> ii libgnome2-0 2.6.1-8 The GNOME 2 library - runtim=
e file
> ii libgnomecanvas2-0 2.6.1.1-2 A powerful object-oriented d=
isplay
> ii libgnomeui-0 2.6.1.1-3 The GNOME 2 libraries (User =
Interf
> ii libgnomevfs2-0 2.6.1.1-5 The GNOME virtual file-syste=
m libr
> ii libgnutls10 1.0.4-3 GNU TLS library - runtime li=
brary
> ii libgpg-error0 0.7-3 library for common error val=
ues an
> ii libgtk2.0-0 2.4.3-3 The GTK+ graphical user inte=
rface=20
> ii libice6 4.3.0.dfsg.1-6 Inter-Client Exchange library
> ii libjpeg62 6b-9 The Independent JPEG Group's=
JPEG=20
> ii liborbit2 1:2.10.2-1.1 libraries for ORBit2 - a COR=
BA ORB
> ii libpango1.0-0 1.4.0-4 Layout and rendering of inte=
rnatio
> ii libpopt0 1.7-4 lib for parsing cmdline para=
meters
> ii libsm6 4.3.0.dfsg.1-6 X Window System Session Mana=
gement
> ii libtasn1-2 0.2.7.0-2 Manage ASN.1 structures (run=
time)
> ii libx11-6 4.3.0.dfsg.1-6 X Window System protocol cli=
ent li
> ii libxml2 2.6.11-1 GNOME XML library
> ii xlibs 4.3.0.dfsg.1-6 X Window System client libra=
ries m
> ii zlib1g 1:1.2.1.1-5 compression library - runtime
>=20
> -- no debconf information
>=20
>=20
> _______________________________________________
> Pkg-grub-devel mailing list
> Pkg-grub-devel@lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-grub-devel
--=20
GnuPG Key fingerprint =3D 113F B290 C6D2 0251 4D84 A34A 6ADD 4937 E20A 525E
--bAr+fMtvBxbbbkvl
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFA/GW1at1JN+IKUl4RAkjMAJ9SPNjyZwipLFAFsNakwqaJUAq0rwCeKFF0
tZFI0fysw4BcQ2OC/EWmdOQ=
=ZdHC
-----END PGP SIGNATURE-----
--bAr+fMtvBxbbbkvl--