Bug#261570: Missed XSI:isms...

[David Weinehall]

On Mon, Jul 26, 2004 at 09:59:28PM +0200, Robert Millan wrote:
> On Mon, Jul 26, 2004 at 09:12:19PM +0200, David Weinehall wrote:
> > 
> > Doh.  I seem to have missed out a `local' in debian/update-grub and
> > a couple of `-a' in util/mkbimage.  The included patch fixes this.
> 
> > diff -ur grub-0.95+cvs20040624-old/debian/update-grub grub-0.95+cvs20040624/debian/update-grub
> > --- grub-0.95+cvs20040624-old/debian/update-grub	2004-07-25 18:14:29.000000000 +0300
> > +++ grub-0.95+cvs20040624/debian/update-grub	2004-07-26 21:55:32.000000000 +0300
> > @@ -201,7 +201,6 @@
> >  # Calls OS-specific convert, and returns a default of
> >  # (hd0,0) if anything goes wrong
> >  convert_default () {
> > -	local tmp
> >  	if tmp=$(convert $1 2>/dev/null) ; then
> >  		echo $tmp
> >  	else
> 
> What does 'local' do? How is it that removing it is harmless?

It declares the variable tmp local...  Since tmp isn't used globally,
and convert_default doesn't call itself recursively, there is no need to
declare it as a local.

[snipped patch]

> This part was already in the package (in debian/patches/). I did also
> commit it in upstream.

Oh, sorry missed that.  Debian packages that use patch-systems are quite
tricky to inspect without building...


Regards: David Weinehall
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/