Bug#235017, Bug#236356, New Debian grubconf-0.5.1-1

[Robert Millan]

reopen 235017
thanks

On Wed, Mar 24, 2004 at 02:44:11PM -0500, Luis R. Rodriguez wrote:
> 
> So I've released a new grubconf deb.
> 
> This fixes Bug#235017, and I was unable to reproduce Bug#236356.
> Grubconf.sf.net had a new grubconf upstream release, 0.5.1 so I've used
> that. This source had some noticeable bugs so I've fixed them for our deb release.

Good.

> I'm still a debian developer in review so I do not yet have upload
> privileges. I believe Robert Millan last uploaded my latest grubconf
> release. This needs to be uploaded as well. Please find complete deb
> sources/deb here:
> 
> http://ruslug.rutgers.edu/~mcgrof/grubconf/

Yep. I'll take care of the upload but first I have to ensure everything
is correct. See below..

> grubconf (0.5.1-1) unstable; urgency=low
> 
>   * new grubconf release: 0.5.1
>   * debian/control: added scrollkeeper to Build-Depends. Fixes 
>     (closes: #235017)

When the package is uploaded, this line will close bug #235017 automaticaly.

OTOH, under normal circumstances you must not close a bug manualy (via
nnn-done@bugs.d.o) before a fixed package is uploaded. This could lead to
the old broken package populate into testing. I'm reopening the bug.

If you want to indicate that the bug is fixed and will be uploaded soon,
you may use the "pending" tag.

>   * debian/control: added "i386 hurd-i386 freebsd-i386 netbsd-i386"
>     to Architecture field. These match the archs for which grub
>     is available.
>   * Unable to reproduce bug #236356.

You should only use changelog entries to indicate changes in the actual
package. For this sort of situation there's the "unreproductible" tag.

>   * removed /usr/include/grubconf/* -- unwanted
>   * debian/control: Added Grub-Devel List <pkg-grub-devel@lists.alioth.debian.org>
>     as Maintainer, added myself as Uploader

Ok.

>   * debian/rules: moved to new cdbs format

Hey, nice.

>   * debian/control: fixed format, removed double spaces and such

That fixes #235345. You should add a (Closes: #nn) statement here.


Looking at the package:

 - Since debian/rules now uses cdbs with debhelper.mk, you need to add
   cdbs to Build-Depends, and set debhelper dependency to (>= 4.1.0)
   (read debhelper.mk for details)

 - gcc 3.2 or later has been default in Debian since 29 Dec 2002. You
   really don't need to Build-Depend on gcc (>= 4:3.2).

> I will be going on vacation later today for 5 days. If anyone needs
> anything I trust pkg-grub-devel team to do the appropriate changes.

We can wait. It's better if you fix them yourself so you learn about
common packaging issues like that.

When you fix the minor problems I found, drop me a note and I'll upload.

-- 
Robert Millan

"[..] but the delight and pride of Aule is in the deed of making, and in the
thing made, and neither in possession nor in his own mastery; wherefore he
gives and hoards not, and is free from care, passing ever on to some new work."

 -- J.R.R.T., Ainulindale (Silmarillion)