Bug#266049: marked as done (update-grub handles four-digit kernel versions wrongly)

Debian Bug Tracking System owner@bugs.debian.org
Thu, 18 Nov 2004 15:48:42 -0800


Your message dated Thu, 18 Nov 2004 18:32:11 -0500
with message-id <E1CUvl5-0003om-00@newraff.debian.org>
and subject line Bug#266049: fixed in grub 0.95+cvs20040624-11
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 16 Aug 2004 14:06:38 +0000
>From taver@idefix.otenet.gr Mon Aug 16 07:06:38 2004
Return-path: <taver@idefix.otenet.gr>
Received: from aiolos.otenet.gr [195.170.0.23] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Bwi8E-0000l9-00; Mon, 16 Aug 2004 07:06:38 -0700
Received: from idefix.otenet.gr (idefix.otenet.gr [212.205.221.130])
	by aiolos.otenet.gr (8.12.11/8.12.11/Debian-3) with ESMTP id i7GE6Znb032626;
	Mon, 16 Aug 2004 17:06:35 +0300
Received: from idefix.otenet.gr (taver@localhost [127.0.0.1])
	by idefix.otenet.gr (8.12.11/8.12.11/Debian-5) with ESMTP id i7GE6aFX002567;
	Mon, 16 Aug 2004 17:06:36 +0300
Received: (from taver@localhost)
	by idefix.otenet.gr (8.12.11/8.12.11/Debian-5) id i7GE6al1002564;
	Mon, 16 Aug 2004 17:06:36 +0300
Message-Id: <200408161406.i7GE6al1002564@idefix.otenet.gr>
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Tavernarakis Costas <taver@otenet.gr>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: update-grub handles four-digit kernel versions wrongly
X-Mailer: reportbug 2.63
Date: Mon, 16 Aug 2004 17:06:36 +0300
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Package: grub
Version: 0.95+cvs20040624-7
Severity: important
Tags: patch

update_grub mishandles 2.6.8.1, in the kopt_version part of the config.

The sed expression on line 507 in update_grub is ambigious with regard to
4-digit kernel version numbers. It will pick 6.8.1 as kernel version out
of 2.6.8.1. It COULD have picked 2.6.8 (which would have made a lot more
sense), however this implementation of sed (sed 4.1.1-1) favors
expanding the latter '*' rather than the initial.

As a result, update_grub IGNORES any kopt_2_6 entries in
/boot/grub/menu.lst and proceeds with the defaults.

One simple solution is to re-write the sed regexp in order not to match
any numbers before the version number.

** /ug.old Mon Aug 16 16:32:56 2004
--- /sbin/update-grub   Mon Aug 16 16:33:33 2004
***************
*** 483,489 ****
  {
        kernel_version=$1

!       version=$(echo $kernel_version | sed
's/.*\([0-9]\+\)\.\([0-9]\+\)\.\([0-9]\+\).*/\1_\2_\3/')
        if [ -n "$version" ] ; then
                while [ -n "$version" ] ; do
                        currentOpt="$(eval "echo \$kopt_$version")"
--- 483,489 ----
  {
        kernel_version=$1

!       version=$(echo $kernel_version | sed
's/[^0-9]*\([0-9]\+\)\.\([0-9]\+\)\.\([0-9]\+\).*/\1_\2_\3/')
        if [ -n "$version" ] ; then
                while [ -n "$version" ] ; do
                        currentOpt="$(eval "echo \$kopt_$version")"


-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.7
Locale: LANG=C, LC_CTYPE=el_GR

Versions of packages grub depends on:
ii  libc6                       2.3.2.ds1-13 GNU C Library: Shared libraries an
ii  libncurses5                 5.4-4        Shared libraries for terminal hand

-- no debconf information

---------------------------------------
Received: (at 266049-close) by bugs.debian.org; 18 Nov 2004 23:38:23 +0000
>From katie@ftp-master.debian.org Thu Nov 18 15:38:23 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CUvr5-0007iA-00; Thu, 18 Nov 2004 15:38:23 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1CUvl5-0003om-00; Thu, 18 Nov 2004 18:32:11 -0500
From: Jason Thomas <jason@debian.org>
To: 266049-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#266049: fixed in grub 0.95+cvs20040624-11
Message-Id: <E1CUvl5-0003om-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Thu, 18 Nov 2004 18:32:11 -0500
Delivered-To: 266049-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 
X-CrossAssassin-Score: 8

Source: grub
Source-Version: 0.95+cvs20040624-11

We believe that the bug you reported is fixed in the latest version of
grub, which is due to be installed in the Debian FTP archive:

grub-disk_0.95+cvs20040624-11_all.deb
  to pool/main/g/grub/grub-disk_0.95+cvs20040624-11_all.deb
grub-doc_0.95+cvs20040624-11_all.deb
  to pool/main/g/grub/grub-doc_0.95+cvs20040624-11_all.deb
grub_0.95+cvs20040624-11.diff.gz
  to pool/main/g/grub/grub_0.95+cvs20040624-11.diff.gz
grub_0.95+cvs20040624-11.dsc
  to pool/main/g/grub/grub_0.95+cvs20040624-11.dsc
grub_0.95+cvs20040624-11_i386.deb
  to pool/main/g/grub/grub_0.95+cvs20040624-11_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 266049@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jason Thomas <jason@debian.org> (supplier of updated grub package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 19 Nov 2004 09:40:53 +1100
Source: grub
Binary: grub-disk grub grub-doc
Architecture: source i386 all
Version: 0.95+cvs20040624-11
Distribution: unstable
Urgency: low
Maintainer: Grub Maintainers <pkg-grub-devel@lists.alioth.debian.org>
Changed-By: Jason Thomas <jason@debian.org>
Description: 
 grub       - GRand Unified Bootloader
 grub-disk  - GRUB bootable disk image
 grub-doc   - Documentation for GRand Unified Bootloader
Closes: 211096 215116 229649 230136 240599 250545 265915 266049 268141 281652
Changes: 
 grub (0.95+cvs20040624-11) unstable; urgency=low
 .
   * Added support for LABEL/UUID to update-grub.
     (Closes: #211096, #215116)
   * Added support for 4 digit kernel version to update-grub.
     (Closes: #266049)
   * Added support for memtest86 to update-grub.
     (Closes: #229649)
   * Fixed update-grub to detect default and previous kernels correctly.
     (Closes: #230136, #240599, #250545, #268141)
   * Update-grub now ignores .dpkg-*
     (Closes: #265915)
   * Added support for fat_stage1_5 to linux build.
     (Closes: #281652)
   * Removed e2fsprogs from Build-Depends-Indep as it is an Essential package.
Files: 
 6312c61d3fa54da18e50cf672b20621f 888 admin optional grub_0.95+cvs20040624-11.dsc
 a1ecf0c6f9f4de39a178a36578a82c86 57457 admin optional grub_0.95+cvs20040624-11.diff.gz
 2a88c3e037c0dda156245ab5c15591bb 358066 admin optional grub_0.95+cvs20040624-11_i386.deb
 0907858e7a2474fb1f7f5be863d633b5 227732 admin optional grub-disk_0.95+cvs20040624-11_all.deb
 e42661f13128fbdf82d1684fb17326ca 259350 doc optional grub-doc_0.95+cvs20040624-11_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBnSzb7cYwRJJSiL4RAjNaAKDzr6sJEJkLdUymxCkP4MK1MGanmQCeJpE4
T+Da3GDgn1LDor5899KolK8=
=DNYB
-----END PGP SIGNATURE-----