Bug#500482: Segmentation fault in grub-probe

Guillem Jover guillem.jover at nokia.com
Tue Oct 28 17:07:36 UTC 2008


Hi,

On Tue, 2008-10-28 at 01:09:24 +0100, Julien Cristau wrote:
> On Mon, Oct 27, 2008 at 23:43:40 +0200, Guillem Jover wrote:
> > +
> > +	      p = grub_strchr (p, '}') + 1;
> > +	      if (p == NULL)
> > +		goto pvs_fail;
> > +
> 
> This test seems buggy.  The +1 needs to be after the NULL check.

Bah! Right, didn't notice. Attached now the patch split in two parts,
one fixing this and another instance of this problem and the other one
fixing this current segfault.

regards,
guillem
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lvm-Fix-possible-NULL-value-handling.patch
Type: text/x-diff
Size: 0 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20081028/050e2811/attachment.patch 


More information about the Pkg-grub-devel mailing list