Bug#608519: grub-pc: 05_debian_theme assumes background image was copied from an installed desktop-base

[Alexander Kurtz]

severity 608519 important
tag 608519 confirmed wontfix
thanks

Hi,

Am Freitag, den 31.12.2010, 19:39 +0000 schrieb Brian Potkin:
> I have a machine running unstable. The background image is
> moreblue-orbit-grub.png which is in /boot/grub. The image was copied
> from desktop-base but the package itself has never been installed on the
> system and, due to space restrictions, never will be.
> 
> The recent upgrade has deleted moreblue-orbit-grub.png and made it
> impossible for it to be used when in /boot/grub. Basically, you can have
> any image in that location provided it isn't moreblue-orbit-grub or
> debian-blueish-wallpaper-640x48!

Unfortunately I can't think of any way to fix this. 05_debian_theme is
already comparing filenames AND checksums to make sure it doesn't delete
user-generated files. I was also thinking about comparing the timestamps
so that problems like yours could be avoided, however if you take a look
at the old postinst code...

        # /boot/grub/ has more chances of being accessible by GRUB
        if test -e /boot/grub/grub.cfg ; then
          for i in /usr/share/grub/unicode.pf2 /usr/share/images/desktop-base/moreblue-orbit-grub.png ; do
            if test -e $i ; then
              cp $i /boot/grub/
            fi
          done
        fi

... you'll see that `cp' was used without the `-a' switch, so timestamps
were not preserved. Therefore I don't think there is any way to
determine whether that file was put there by you or GRUB's postinst.

That was the bad news. However, there is also good news:

 a) 05_debian_theme compares both filename and checksum. If you rename 
    the file to something like `my_custom_background.png' everything 
    should work just fine.

 b) The code which cleans up old background images shouldn't be 
    necessary any more if you had at least the squeeze version 
    installed. I'm therefore planning to remove that code at some
    point after squeeze's release. The patch is already written,
    I'm just waiting for the mail from debian-announce at d.o ;-)

I hope this helps!

Alexander Kurtz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20110102/30cee89d/attachment-0001.pgp>