Bug#608263: /etc/grub.d/05_debian_theme: new 05_debian_theme doesn't allow no background image

[Alexander Kurtz]

Am Mittwoch, den 05.01.2011, 19:03 +0100 schrieb Mario 'BitKoenig' Holbe:
> You re-do GRUB_BACKGROUND because you think you can do better than
> 00_header - which may not be wrong (except the colors :)), but it's not
> 05_debian_theme's job and may clash with others not expecting it.
You have to remove exactly one line to disable that feature.

> You do handle images in /boot/grub unsolicited
You have to remove exactly one line to disable that feature.

> For the meantime not to mix them both up too much, how about using
> something like GRUB_DEBIAN_BACKGROUND or DEBIAN_GRUB_BACKGROUND instead
> of GRUB_BACKGROUND for "the more sophisticated Debian way to handle GRUB
> images"?
No, I can't just introduce new configuration variables[1].

> I don't like to decide that.
IMO it's more comfortable - that can't be a bad thing.

> IMHO it's bad for existing systems which now unexpectedly get a
> graphical console just because they had something lingering around in
> /boot/grub they probably didn't even know about.
Oh come on! If you have an image file in /boot/grub/, you probably have
put it there yourself.

> I mean, if you install desktop-base you expect (to some extent) to get a
> shiny gleamy look everywhere, but if you don't...
...then you won't get any GRUB background image, unless you specifically
asked for it.

> Probably it's also bad for systems that have other ways of setting up a
> grub-background which includes copying images to /boot/grub. You now set
> them up a graphical console and you don't know if you (re-)do it before
> or after them, i.e. if you probably make it worse.
Those packages would have to hack grub.cfg manually. I really don't care
about such broken packages.

> The previous behaviour of 05_debian_theme was to install
> moreblue-orbit-grub.png from desktop-base with matching colors if
> possible. If not, set colors for the text interface.
> But now you even remove moreblue-orbit-grub.png (which is fine with me,
> btw.) - thats not close to the previous behaviour :)
Yes it is. It's just that the default background now has a different
name.

> Btw: Even though the removal of moreblue-orbit-grub.png is fine with me,
> I personally don't like the way to do it: it was installed in a package
> control script, it should be removed in a package control script.
Installing it in the postinst was wrong. Removing it there would be even
more. However, as said earlier[2] this code will be removed once squeeze
is released. Still, feel free to submit a patch which moves the code to
the postinst.

Let me summarise:
 a) I intend to give the user the possibility to have no background 
    image at all.
 b) I'm thinking about not setting any default background colors and
    just using GRUB's defaults.

If you have anything else you want to discuss, please file separate bug
reports.

Best regards

Alexander Kurtz

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=608283#36
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=608519#56
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20110105/2132a28e/attachment.pgp>