Bug#803625: grub-common: 10_linux doesn't merge rootflags= from GRUB_CMDLINE_LINUX*

[Christoph Anton Mitterer]

Package: grub-common
Version: 2.02~beta2-29
Severity: important


Hi.

That's basically a follor-up or at least related to #803624.

When the root-fs is on a btrfs subvolume (and perhaps in other cases
as well), 10_linux adds a rootflags= to the kernel parameters, not
merging any possibly already set such option in
GRUB_CMDLINE_LINUX_DEFAULT or GRUB_CMDLINE_LINUX.


Now coming back to my degraded-RAID-should-still-boot scenario from
#803624, even when I manually set GRUB_CMDLINE_LINUX=rootflags=degraded
things won't work (and the boot fails when a disk is e.g. missing).

It results in a grub.cfg line like:
  linux   /root/boot/vmlinuz-4.2.0-1-amd64 root=UUID=d430d7ee-8059-11e5-9834-502690aa641f ro rootflags=subvol=root rootflags=degraded
and apparently the 2nd rootflags= is simply ignored.


When I manually change the line to:
  linux   /root/boot/vmlinuz-4.2.0-1-amd64 root=UUID=d430d7ee-8059-11e5-9834-502690aa641f ro rootflags=subvol=root,degraded
everything works (even though I don't know what would happen if there was a subvolume named "root,degraded",
so perhaps one needs some quoting in that case?).


Any ideas?

Cheers,
Chris.