Bug#603041: gst-visualize-m.m imports File::Basename which creates unnecessary perl dependency

[Evan Broder]

Package: gstreamer0.10-plugins-base-apps
Version: 0.10.30.4-1
Severity: minor
Tags: patch

The gst-visualize-m.m script in gstreamer0.10-plugins-base-apps
imports Base::Filename at the top of the script, but then doesn't use
any functions from that module.

In Ubuntu we're attempting to clean up some of the dependencies of our
core desktop packages, and in particular we're looking at trying to
drop perl dependencies to perl-base dependencies when that's possible.

Since File::Basename is the only imported module not provided by
perl-base, dropping this import would allow
gstreamer0.10-plugins-base-apps' dependency to be demoted.

Attached is the patch that we applied in Ubuntu for this. I've also
forwarded the issue to the upstream GStreamer developers
(https://bugzilla.gnome.org/show_bug.cgi?id=634522)
-------------- next part --------------
--- debian/changelog	2010-11-02 08:44:13 +0000
+++ debian/changelog	2010-11-10 04:22:33 +0000
@@ -1,3 +1,12 @@
+gst-plugins-base0.10 (0.10.30.4-1ubuntu1) natty; urgency=low
+
+  * debian/patches/100_no_file-basename.patch: gst-visualize-0.10 imports
+    File::Basename but doesn't use it. Drop that import.
+  * With that, this package no longer uses anything from perl or
+    perl-modules, so drop the Perl dependency to perl-base.
+
+ -- Evan Broder <evan at ebroder.net>  Tue, 09 Nov 2010 20:17:18 -0800
+
 gst-plugins-base0.10 (0.10.30.4-1) experimental; urgency=low
 
   * New upstream pre-release: 

=== modified file 'debian/control.in'
--- debian/control.in	2010-11-02 08:44:13 +0000
+++ debian/control.in	2010-11-10 04:22:33 +0000
@@ -1,7 +1,8 @@
 Source: gst-plugins-base at GST_ABI@
 Section: libs
 Priority: optional
-Maintainer: Maintainers of GStreamer packages <pkg-gstreamer-maintainers at lists.alioth.debian.org>
+Maintainer: Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>
+XSBC-Original-Maintainer: Maintainers of GStreamer packages <pkg-gstreamer-maintainers at lists.alioth.debian.org>
 Uploaders: Loic Minier <lool at dooz.org>,
            Sebastien Bacher <seb128 at debian.org>,
            Sebastian Dr?ge <slomo at debian.org>,

=== added file 'debian/patches/100_no_file-basename.patch'
--- debian/patches/100_no_file-basename.patch	1970-01-01 00:00:00 +0000
+++ debian/patches/100_no_file-basename.patch	2010-11-10 04:22:33 +0000
@@ -0,0 +1,13 @@
+Index: gst-plugins-base0.10/tools/gst-visualise-m.m
+===================================================================
+--- gst-plugins-base0.10.orig/tools/gst-visualise-m.m	2010-11-09 20:15:33.565417497 -0800
++++ gst-plugins-base0.10/tools/gst-visualise-m.m	2010-11-09 20:15:38.595099835 -0800
+@@ -7,8 +7,6 @@
+ 
+ ### packages
+ 
+-use File::Basename;
+-
+ 
+ my (%pipes, %cfg);
+ 

=== modified file 'debian/patches/series'
--- debian/patches/series	2010-11-02 08:44:13 +0000
+++ debian/patches/series	2010-11-10 04:22:33 +0000
@@ -1,2 +1,3 @@
 10_gnome-vfs-dav-url.patch
 99_ltmain_as-needed.patch
+100_no_file-basename.patch

=== modified file 'debian/rules'
--- debian/rules	2010-11-02 08:44:13 +0000
+++ debian/rules	2010-11-10 04:22:33 +0000
@@ -164,7 +164,7 @@
 	-rm -rf $(CURDIR)/fake-home
 
 binary-post-install/$(gst_pkgname)-plugins-base-apps::
-	dh_perl
+	dh_perl -d
 
 DEB_DH_MAKESHLIBS_ARGS_$(gst_plugins_base_lib) += -X "/usr/lib/gstreamer-$(gst_abi)" -V $(gst_plugins_base_lib_dep) -- -c4
 DEB_INSTALL_DOCS_ALL += debian/README.Debian NEWS