[Pkg-gtkpod-devel] Bug#451749: gtkpod fails to add files to a new local repository, patch from ubuntu available

John Dong jdong at ubuntu.com
Sun Nov 18 08:01:47 UTC 2007


Package: gtkpod
Version: 0.99.10-3

Hi, I have noticed that Debian's gtkpod package contains a bug recently
fixed in Ubuntu:
https://bugs.launchpad.net/ubuntu/+source/gtkpod-aac/+bug/145506

Full details and reproducing steps can be found on that bug report.
Attached is the dpatch I wrote for Ubuntu that resolves this bug, taken
from upstream's SVN as noted in the comments. It should apply cleanly to
Debian gtkpod too.

Cheers,

John
-------------- next part --------------
#! /bin/sh /usr/share/dpatch/dpatch-run
## itdb-set-local-to-imported.dpatch by John Dong <jdong at ubuntu.com>
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: Set local iTunesDB's imported status to TRUE
## DP: Stolen-from: Upstream SVN revno 1596
## DP:  Resolves a bug where a fresh Local repository refuses to accept
## DP:  new track additions, such as LP #145506

@DPATCH@
diff -urNad gtkpod-aac-0.99.10~/src/display_itdb.c gtkpod-aac-0.99.10/src/display_itdb.c
--- gtkpod-aac-0.99.10~/src/display_itdb.c	2007-06-27 15:29:33.000000000 -0400
+++ gtkpod-aac-0.99.10/src/display_itdb.c	2007-11-16 23:59:54.000000000 -0500
@@ -998,8 +998,16 @@
 	    itdb_playlist_set_mpl (pl);
 	    itdb_playlist_add (itdb, pl, -1);
 
-	    eitdb->data_changed = FALSE;
-	    eitdb->itdb_imported = FALSE;
+           if ((type & GP_ITDB_TYPE_PODCASTS) || (type & GP_ITDB_TYPE_LOCAL))
+             {
+               eitdb->data_changed = TRUE;
+               eitdb->itdb_imported = TRUE;
+             }
+           else
+             {
+               eitdb->data_changed = FALSE;
+               eitdb->itdb_imported = FALSE;
+             }
 	}
 	else
 	{
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-gtkpod-devel/attachments/20071118/91807663/attachment.pgp 


More information about the Pkg-gtkpod-devel mailing list