[Git][haskell-team/DHG_packages][master] http-client: Upgrading from 0.7.11 to 0.7.13.1

Ilias Tsitsimpis (@iliastsi) gitlab at salsa.debian.org
Sun Oct 23 16:24:55 BST 2022



Ilias Tsitsimpis pushed to branch master at Debian Haskell Group / DHG_packages


Commits:
3d8e541f by Ilias Tsitsimpis at 2022-10-23T18:22:13+03:00
http-client: Upgrading from 0.7.11 to 0.7.13.1

- - - - -


2 changed files:

- p/haskell-http-client/debian/changelog
- p/haskell-http-client/debian/patches/disable-external-network-connection-test.diff


Changes:

=====================================
p/haskell-http-client/debian/changelog
=====================================
@@ -1,3 +1,9 @@
+haskell-http-client (0.7.13.1-1) unstable; urgency=medium
+
+  * New upstream release
+
+ -- Ilias Tsitsimpis <iliastsi at debian.org>  Sun, 23 Oct 2022 18:20:07 +0300
+
 haskell-http-client (0.7.11-1) unstable; urgency=medium
 
   * New upstream release (Closes: #856700)


=====================================
p/haskell-http-client/debian/patches/disable-external-network-connection-test.diff
=====================================
@@ -2,7 +2,7 @@ Index: b/test/Network/HTTP/ClientSpec.hs
 ===================================================================
 --- a/test/Network/HTTP/ClientSpec.hs
 +++ b/test/Network/HTTP/ClientSpec.hs
-@@ -15,115 +15,4 @@ main :: IO ()
+@@ -17,140 +17,4 @@ main :: IO ()
  main = hspec spec
  
  spec :: Spec
@@ -13,6 +13,31 @@ Index: b/test/Network/HTTP/ClientSpec.hs
 -        res <- httpLbs req man
 -        responseStatus res `shouldBe` status200
 -
+-    -- Test the failure condition described in https://github.com/snoyberg/http-client/issues/489
+-    it "keeps connection alive long enough" $ do
+-        req <- parseUrlThrow "http://httpbin.org/"
+-        man <- newManager defaultManagerSettings
+-        res <- responseOpen req man
+-        responseStatus res `shouldBe` status200
+-        let
+-            getChunk = responseBody res
+-            drainAll = do
+-                chunk <- getChunk
+-                if BS.null chunk then pure () else drainAll
+-
+-        -- The returned `BodyReader` used to not contain a reference to the `Managed Connection`,
+-        -- only to the extracted connection and to the release action. Therefore, triggering a GC
+-        -- would close the connection even though we were not done reading.
+-        performGC
+-        -- Not ideal, but weak finalizers run on a separate thread, so it's racing with our drain
+-        -- call
+-        threadDelay 500000
+-
+-        drainAll
+-        -- Calling `responseClose res` here prevents the early collection from happening in this
+-        -- test, but in a larger production application that did involve a `responseClose`, it still
+-        -- occurred.
+-
 -    describe "method in URL" $ do
 -        it "success" $ do
 -            req <- parseUrlThrow "POST http://httpbin.org/post"



View it on GitLab: https://salsa.debian.org/haskell-team/DHG_packages/-/commit/3d8e541f7596fa84bfead3d9a0c9f9d6baffd1e2

-- 
View it on GitLab: https://salsa.debian.org/haskell-team/DHG_packages/-/commit/3d8e541f7596fa84bfead3d9a0c9f9d6baffd1e2
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-haskell-commits/attachments/20221023/a6310376/attachment-0001.htm>


More information about the Pkg-haskell-commits mailing list