[Pkg-hpijs-devel] Bug#500183: Bug#496660: Bug#500183: Patch not applied in the current unstable version and not present in lenny

[Vincent Danjean]

close 500183 2.8.6.b-3
notfound 500183 2.8.6.b-3
thanks

Mark Purcell wrote:
> On Sunday 16 November 2008 04:50:39 Vincent Danjean wrote:
>>   I'm sorry to tell you that the patch proposed in 500183 in not
>> applied in hplip 2.8.6.b-3 (whereas the changelog says it has been
>> applied in 2.8.6.b-2)
>>   Manually patching /usr/bin/hp-makeuri (ie modifying the 3 lines
>> with "vi") with the patch provided in 500183 solves 500183 and 496660.
> 
> Vincent,
> 
> As far as I can tell the patch has been applied to -3.

You are right.

Here is what happened : I've found this bug on a etch->lenny upgrade.
I've looked at the bts, found 500183.
I installed hplip 2.8.6.b-3 as hp-makeuri is in this package.

But I did not see that hp-makeuri is a link to ../share/hplip/makeuri.py
which is in another package (hplip-data) [I just see it know] and I did not
upgrade hplip-data. The dependence field was ok :
Package: hplip
Version: 2.8.6.b-3
Depends: [...], hplip-data (>> 2.8.6.b), hplip-data (<< 2.8.6.b.1)
So having hplip-data 2.8.6.b-1 was ok

An when I looked into /usr/bin/hp-makeuri, I did not see that I was
following the symbolic link and was looking into /usr/share/hplip/makeuri.py
(not upgraded so not patched)

Sorry for the mess. I closed again this bug with this message.

Note: I still consider that this bug should be closed for lenny.

  Best regards,
    Vincent

> Can you provide the output of:

I just retested to be sure :

vdanjean at eyak:~$ dpkg -l hplip
[...]
ii  hplip                   2.8.6.b-3               HP Linux Printing and Imaging System (HPLIP)
vdanjean at eyak:~$ tail -n35 /usr/bin/hp-makeuri | grep -A 1 -B 1 fax

    if fax_uri:
        if fax_quiet_mode:
            log.info(fax_uri)

        elif not quiet_mode:
            log.info("HP Fax URI: %s" % fax_uri)

    elif not fax_uri and fax_quiet_mode:
        log.error("Device does not support fax.")

vdanjean at eyak:~$ dpkg -l hplip-data
[...]
ii  hplip-data              2.8.6.b-1               HP Linux Printing and Imaging - data files
vdanjean at eyak:~$ sudo apt-get install hplip-data
[...]
The following packages will be upgraded:
  hplip-data
1 upgraded, 0 newly installed, 0 to remove and 1 not upgraded.
[...]
Setting up hplip-data (2.8.6.b-3) ...
vdanjean at eyak:~$ tail -n35 /usr/bin/hp-makeuri | grep -A 1 -B 1 fax

    if fax_uri:
        if fax_quiet_mode:
            print fax_uri

        elif not quiet_mode:
            log.info("HP Fax URI: %s" % fax_uri)

    elif not fax_uri and fax_quiet_mode:
        log.error("Device does not support fax.")

vdanjean at eyak:~$

-- 
Vincent Danjean       GPG key ID 0x9D025E87         vdanjean at debian.org
GPG key fingerprint: FC95 08A6 854D DB48 4B9A  8A94 0BF7 7867 9D02 5E87
Unofficial pacakges: http://www-id.imag.fr/~danjean/deb.html#package
APT repo:  deb http://perso.debian.org/~vdanjean/debian unstable main