[Pkg-ime-devel] Bug#771390: ibus-array: What exactly was the changes to 0.1.0-1
Osamu Aoki
osamu at debian.org
Sat Nov 29 10:32:15 UTC 2014
Hi,
Let's move this to BTS so anyone can read this.
On Sat, Nov 29, 2014 at 03:04:16PM +0800, Keng-Yu Lin wrote:
> Thanks for explaining this to me. I understand now. :-)
So let's think how to get these fixes accepted to jessie.
Basic rule:
Make it easy for the release manager to declare this is
matching their announced release policy with no efforts on their part.
https://release.debian.org/jessie/freeze_policy.html
| There are some packages we know we won't approve. So as not to have
| everyone contact us at once about such packages, here are the guidelines
| for changes that will be accepting into testing during the freeze:
|
| * targeted fixes for release critical bugs (i.e., bugs of severity
| critical, grave, and serious) in all packages (applies during the entire
| freeze (ok for TPU));
If you raise bug severity of #771390, you can do it anytime. (But let's
not do it now)
| * fixes for severity: important bugs in packages of priority: optional or
| extra, only when this can be done via unstable (until the 5th of
| December 2014);
OK we still have few days to fix bug #771390 (important) for
introspection.
| * translation updates and documentation fixes that are included with fixes
| for the above criteria (until the 5th of January 2015);
OK your PO and related updates fit into this even in December.
| translation updates and documentation fixes, via TPU when included with
| * other TPU-applicable fixes. (until the 5th of January 2015)
| pre-approved fixes (until the 5th of January 2015);
Let's not do TPU for now.
> > Let's discuss positive side.
> >
> > Am I correct to described this situation as follows:
> >
> > 1. Although ibus-array 0.0.4-1 has no bug reported, ibus-array setup is
> > completely broken due to missing support for "import ibus".
> > important or grave bug (maintainer's call) This needs to be fixed by
> > supporting gnome introspection for ibus.
> Yes. setup.py is broken in ibus-array 0.0.4-1.
Bug #771390 filed.
> > 2. Although this is new upstream, diff is very small. (It could have
> > been smaller if there were not some formatting changes.) The changes
> > are practically all focused on gnome introspection for ibus and new
> > translation which is sure to be OK under current freeze policy.
> Yes too. ibus-array 0.1.0 fixes
> (1) Add GTK introspection support for setup.py
> (2) Made all conf keys in lowercase because ibus-config always uses
> the lowercase
> (3) Add gettext support and new translation
Release team does not like a big patch. You have been using subversion.
For the ease of tracking changes, I exported it to git and did few
manual tagging. Its tar.xz can be found at:
https://people.debian.org/~osamu/ibus-array.tar.xz (7MB)
(If you do not mind, moving code to github etc. like other ibus modules
may be an idea using this git repo as the base.)
$ git shortlog 0.0.4.. # highligts by me
lexicall at gmail.com (10):
Use Gobject introspection in the setup dialog
Fixed main setup ui due to ibus_config API changes
Fixed ibus array engine due to ibus config API changes
IBusText is not a gboject now; no need to unref it
ibus config seems to save all the keys in the lowercase
reformat the coding style *******
reformat the coding style *******
Add gettext support
Fix typo in zh_TW.po
update the copyright *******
The last one is not in 0.1.0. So except 2 commits with "reformat the
coding style", these are very much targeted fixes.
I have made a set of patches using "git format-patch" for these 9 patches.
(attached)
As for Debian revision, you only changed translation support.
$ git diff HEAD~
diff --git a/debian/changelog b/debian/changelog
index 9fb3fd8..42a7f3c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+ibus-array (0.1.0-1) unstable; urgency=low
+
+ * Imported Upstream version 0.1.0
+
+ -- Keng-Yu Lin <kengyu at lexical.tw> Sat, 01 Nov 2014 20:48:51 +0800
+
ibus-array (0.0.4-1) unstable; urgency=medium
* Team upload.
diff --git a/debian/control b/debian/control
index a69b427..f3a7494 100644
--- a/debian/control
+++ b/debian/control
@@ -12,6 +12,7 @@ Build-Depends: autoconf (>= 2.5),
libsqlite3-dev,
libtool (>= 2.2),
pkg-config,
+ intltool,
python-all (>= 2.6.6-3~)
Standards-Version: 3.9.6
Homepage: http://code.google.com/p/ibus-array/
Hmmmm... I think we have a case where we may get OK by the release
manager. If not we can update introspection fix via TPU.
Osamu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-Gobject-introspection-in-the-setup-dialog.patch
Type: text/x-diff
Size: 4045 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ime-devel/attachments/20141129/88eace1a/attachment-0009.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fixed-main-setup-ui-due-to-ibus_config-API-changes.patch
Type: text/x-diff
Size: 2787 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ime-devel/attachments/20141129/88eace1a/attachment-0010.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Fixed-ibus-array-engine-due-to-ibus-config-API-chang.patch
Type: text/x-diff
Size: 6160 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ime-devel/attachments/20141129/88eace1a/attachment-0011.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-IBusText-is-not-a-gboject-now-no-need-to-unref-it.patch
Type: text/x-diff
Size: 871 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ime-devel/attachments/20141129/88eace1a/attachment-0012.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-ibus-config-seems-to-save-all-the-keys-in-the-lowerc.patch
Type: text/x-diff
Size: 2385 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ime-devel/attachments/20141129/88eace1a/attachment-0013.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-reformat-the-coding-style.patch
Type: text/x-diff
Size: 7978 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ime-devel/attachments/20141129/88eace1a/attachment-0014.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-reformat-the-coding-style.patch
Type: text/x-diff
Size: 933 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ime-devel/attachments/20141129/88eace1a/attachment-0015.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Add-gettext-support.patch
Type: text/x-diff
Size: 7406 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ime-devel/attachments/20141129/88eace1a/attachment-0016.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Fix-typo-in-zh_TW.po.patch
Type: text/x-diff
Size: 774 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ime-devel/attachments/20141129/88eace1a/attachment-0017.patch>
More information about the Pkg-ime-devel
mailing list