[Pkg-ime-devel] Bug#745721: Name collision between libpinyin and libzhuyin (Was: Bug#745721: Bug#745721: RFS: libzhuyin/0.9.93-1)

[ChangZhuo Chen (陳昌倬)]

On Tue, Sep 30, 2014 at 02:51:05PM -0300, Eriberto wrote:
> Hi ChangZhuo,
> 
> 1. I found several differences between your orig.tar.gz and the
> tarball in upstream site. I used the diff command to compare. Can you
> check this?

The tarball is from sourceforge [0] with the following SHA256.

-   cd4b7a73f44715050d2405491724ec657e40ee86946fc78321a514c37adfae6f

It is the same one in *.dsc file.

Do you use the tarball from github? The tarball from github does not
contain data file used by libzhuyin, so upstream suggested using tarball
from sourceforge [1].

> 2. d/control: please, change the DH level from 9.0.0 to 9.

Thanks, I will update it.

> 3. d/copyright: there are new authors and dates in new upstream code.
> You need to review all files Use 'grep -sriA25 copyright * | less' to
> help you.

I don't find any new copyright not listed in d/copyright except from
"FSF" and "X Consortium". Both "FSF" and "X Consortium" copyright are in
autotools generating files, so I think I don't need to list them, right?

The "2002-2006 James Su <suzhe at tsinghua.edu.cn>" does not present
anywhere except AUTHORS file, shall I keep it in d/copyright?

> 
> 4. You have a Lintian message:
> 
> I: libzhuyin6: spelling-error-in-binary
> usr/lib/x86_64-linux-gnu/libzhuyin.so.6.0.0 tEH the
> 
> Please, create a lintian override and put a comment about this false positive.

Thanks, I will update it.

> 
> 5. After the build, I used the command 'blhc --all
> libzhuyin_0.9.99.20140929-1_amd64.build' to see about the build
> status. No data. So, I used 'export V=1' in debia/rules and blhc show
> me several issues. To fix all issues, please, add to d/rules:
> 
> export V = 1
> export DEB_BUILD_MAINT_OPTIONS = hardening=+all

Thanks, I will update it.
 

[0] http://sourceforge.net/projects/libzhuyin/?source=directory
[1] https://github.com/libzhuyin/libzhuyin/issues/3

-- 
ChangZhuo Chen (陳昌倬) <czchen at gmail.com>
http://czchen.info/
Key fingerprint = EC9F 905D 866D BE46 A896  C827 BE0C 9242 03F4 552D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-ime-devel/attachments/20141001/0b782c72/attachment.sig>