[PKG-IRC-Maintainers] inspircd 2.0.16

[Guillaume Delacour]

Le dimanche 13 juillet 2014 à 20:21 +0200, Andreas Metzler a écrit :
> On 2014-07-13 Guillaume Delacour <gui at iroqwa.org> wrote:
> [...]
> > The major blocker is finding a sponsor, i'll appreciate if you can
> > validate the package and upload it to the archive; i personally use the
> > package i've previously made on Wheezy since many days without issues.
> 
> Hello,
> 
> Thank you for the quick reaction. I will happily sponsor this when it
> is ready.
> 
> I have just given it a short shot. Let me give you a first feedback. I
> am running testing with systemd here and had problems getting the
> daemon started. ("Failed to write PID-file")
> 
> Looking at the package there are a couple of problems in this area.
> ------------------
> /etc/inspircd/inspircd.conf:
> <pid file="/var/run/inspircd.pid">
> 
> /lib/systemd/system/inspircd.service
> PIDFile=/var/run/inspircd/inspircd.pid
> ------------------
> 
> 1. inspircd tries to write a pidfile in /var/run/inspircd.pid and
> systemd will look in a different location for a pidfile.
> 
> 2. systemd starts inspircd as user irc, who has no write permissions
> on /var/run.
> 
> 3. Afaiu
> <http://www.freedesktop.org/software/systemd/man/systemd.service.html>
> actually the pidfile directive should only be used for forking
> daemons, but the service runs with --nofork.
> 
> 4. debian/inspircd.tmpfiles.d.conf would generate (/var)/run/inspircd
> but it not shipped.
> 
> -------------
> I think (but really I am just a beginner at systemd) the proper fix
> would be to drop the PIDFile entry from the service file, delete
> debian/inspircd.tmpfiles.d.conf and fix inspircd to not try to write a
> pidfile when invoked with --nofork or at least add a option to disable
> pid-file writing.
> 
> The second-best fix would be to ship the tmpfile in the package
> (mv debian/inspircd.tmpfiles.d.conf debian/inspircd.tmpfile) and
> change the pid file location in both inspircd.conf and the int
> script.

I don't use systemd (so i mis-configured it for this package) and my
tests on a fresh Sid installed virtual machine were a bit wrong months
ago.

I also saw a few minutes ago that the file
debian/inspircd.tmpfiles.d.conf was not shipped automagically in the
package and this is because of the name i used.

I'll fix this in a few hours with my other package which has a similar
bug opened.

> 
> If my comment in 3. is correct the pidfile directive should be dropped
> no matter what.
> 
> cu Andreas
> 

-- 
Guillaume Delacour <gui at iroqwa.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-irc-maintainers/attachments/20140715/ec4b2636/attachment.sig>