[Pkg-iscsi-maintainers] Bug#581200: iscsitarget-source applies kernel compatibility patches the wrong way

[Ritesh Raj Sarraf]

Hello,

On Tuesday 11 May 2010 19:56:48 Markus Schuster wrote:
> I've "backported" iscsitarget to lenny (just used the Debian sources to
> produce binary packages) and want to use lennys 2.6.26 kernel. In general
> upstream iscsitarget works with this kernel just fine, but debian/rules for
>

I have targeted this version for squeeze. For lenny, I have no plans and would 
suggest you to stick with the version shipped in lenny. Patches are welcome 
though.
 
> iscsitarget-source does the following:
> > kdist_config: prep-deb-files
> > # ... additional kernel specific things to configure...
> > 
> >         test -f patches/compat-$(KERN_VER).patch && patch -p1 <
> > 
> > patches/compat-$(KERN_VER).patch
> 
> The test && patch construct is not fully correct, as you have to apply ALL
> compatibility patches between the desired target version and the version,
> iscsitargt compiles with without patch.

I am not sure what you mean here. Squeeze will ship with 2.6.32. KERN_VER will 
detect it and will accordingly assign itself the value 2.6.32. If you will be 
running squeeze with the supported kernel, iscsitarget will apply the correct 
patch.

> For example to be able to produce a working kernel module for 2.6.26 you
> have to apply the following patches:
> 
> compat-2.6.32.patch
> compat-2.6.31.patch
> compat-2.6.30.patch
> compat-2.6.29.patch
> compat-2.6.28.patch
> compat-2.6.25-2.6.27.patch
> 
> So some sort of loop would be needed...

As I said, I have no plans for lenny in this upload but am open to patches.
BTW, how do you conclude that it needs all patches and not just 
compat-2.6.25-2.6.27.patch ?


-- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
"Necessity is the mother of invention."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-iscsi-maintainers/attachments/20100511/aaeefb03/attachment.pgp>