Bug#326176: marked as done (Various problems with starting/stopping via /etc/init/jetty start/stop)

Debian Bug Tracking System owner at bugs.debian.org
Mon Sep 19 17:03:37 UTC 2005


Your message dated Mon, 19 Sep 2005 07:17:06 -0700
with message-id <E1EHMSA-0005cS-00 at spohr.debian.org>
and subject line Bug#326176: fixed in jetty 5.1.5rc1-4
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 2 Sep 2005 07:41:11 +0000
>From oyvind.harboe at zylin.com Fri Sep 02 00:41:11 2005
Return-path: <oyvind.harboe at zylin.com>
Received: from master.debian.org [146.82.138.7] 
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1EB6Ah-0001sk-00; Fri, 02 Sep 2005 00:41:11 -0700
Received: from (localhost.localdomain) [212.33.152.109] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1EB6Ae-0006xE-00; Fri, 02 Sep 2005 02:41:08 -0500
Content-Type: multipart/mixed; boundary="===============0899362563=="
MIME-Version: 1.0
From: =?iso-8859-1?q?=D8yvind_Harboe?= <oyvind.harboe at zylin.com>
To: Debian Bug Tracking System <submit at bugs.debian.org>
Subject: Various problems with starting/stopping via /etc/init/jetty start/stop
X-Mailer: reportbug 3.15
Date: Fri, 02 Sep 2005 10:35:54 +0200
X-Debbugs-Cc: oyvind.harboe at zylin.com
Message-Id: <E1EB6Ae-0006xE-00 at master.debian.org>
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-9.0 required=4.0 tests=BAYES_00,HAS_PACKAGE,
	OUR_MTA_MSGID,X_DEBBUGS_CC autolearn=ham 
	version=2.60-bugs.debian.org_2005_01_02

This is a multi-part MIME message sent by reportbug.

--===============0899362563==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: jetty
Version: 5.1.5rc1-2
Severity: important
Tags: patch


  * Fixed rc script /etc/init.d/jetty. "stop" could leave dangling
  /var/run/jetty.pid. Fixed this by adding "--oknodo" to 
  "start-stop-daemon --stop" command
  * Removed trailing "/" from LOGDIR which caused
  /var/log/out.log not to be created.
  * /etc/init.d/jetty start will now deal more gracefully with a 
  dangling /var/run/jetty.pid. A dangling jetty.pid is detected
  and ignored.


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.8-2-386
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages jetty depends on:
ii  adduser                   3.64           Add and remove users and groups
pn  jikes | j2sdk1.3 | j2sdk1 <none>         (no description available)
ii  libcommons-logging-java   1.0.4-2        The commmon wrapper interface for 
ii  libmx4j-java              2.0.1-4        An open source implementation of t
ii  libservlet2.4-java        5.0.30-2       Servlet 2.4 and JSP 2.0 Java class
ii  libtomcat4-java           4.1.31-3       Java Servlet engine -- core librar
ii  libxerces2-java           2.6.2-2        Validating XML parser for Java wit
ii  sun-j2sdk1.5 [j2re1.5]    1.5.0+update04 Java(TM) 2 SDK, Standard Edition, 

jetty recommends no packages.

-- no debconf information

--===============0899362563==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="jettyfix.txt"

Index: changelog
===================================================================
RCS file: /cvsroot/pkg-java/jetty/debian/changelog,v
retrieving revision 1.5
diff -u -r1.5 changelog
--- changelog	30 Aug 2005 12:32:22 -0000	1.5
+++ changelog	2 Sep 2005 07:40:23 -0000
@@ -1,3 +1,16 @@
+
+  * Fixed rc script /etc/init.d/jetty. "stop" could leave dangling
+  /var/run/jetty.pid. Fixed this by adding "--oknodo" to 
+  "start-stop-daemon --stop" command
+  * Removed trailing "/" from LOGDIR which caused
+  /var/log/out.log not to be created.
+  * /etc/init.d/jetty start will now deal more gracefully with a 
+  dangling /var/run/jetty.pid. A dangling jetty.pid is detected
+  and ignored.
+  
+ -- Oyvind Harboe <oyvind.harboe at zylin.com> 
+  
+  	
 jetty (5.1.5rc1-3) unstable; urgency=low
 
   * Removed -v from ant opts during build.
Index: jetty.init
===================================================================
RCS file: /cvsroot/pkg-java/jetty/debian/jetty.init,v
retrieving revision 1.3
diff -u -r1.3 jetty.init
--- jetty.init	30 Aug 2005 12:32:22 -0000	1.3
+++ jetty.init	2 Sep 2005 07:40:24 -0000
@@ -68,7 +68,7 @@
                                                                                 
 # Define other required variables
 PIDFILE="/var/run/$NAME.pid"
-LOGDIR="/var/log/jetty/"
+LOGDIR="/var/log/jetty"
 WEBAPPDIR="$JETTY_HOME/webapps"
 
 ##################################################
@@ -89,23 +89,24 @@
 ##################################################
 case "$1" in
   start)
-        echo -n "Starting $DESC: "
+	if start-stop-daemon --quiet --test --start --pidfile "$PIDFILE" \
+	                --user "$JETTY_USER" --startas "$JAVA" > /dev/null; then 
+
 
-        if [ -f $PIDFILE ]
-        then
-            echo "already running."
-            exit 1
-        fi
 
-	# Look for rotatelogs/rotatelogs2
-	if [ -x /usr/sbin/rotatelogs ]; then
+	    # Look for rotatelogs/rotatelogs2
+	    if [ -x /usr/sbin/rotatelogs ]; then
 		ROTATELOGS=/usr/sbin/rotatelogs
-	else
+	    else
 		ROTATELOGS=/usr/sbin/rotatelogs2
-	fi
+	    fi
 
-	if start-stop-daemon --quiet --test --start --pidfile "$PIDFILE" \
-	                --user "$JETTY_USER" --startas "$JAVA" > /dev/null; then 
+	    if [ -f $PIDFILE ]
+		then
+			echo "$PIDFILE exists, but jetty was not running. Ignoring $PIDFILE"
+	    fi
+
+	    echo -n "Starting $DESC: "
 		su -p -s /bin/sh "$JETTY_USER" \
 			-c "$ROTATELOGS \"$LOGDIR/out.log\" 86400" \
 			< "$LOGDIR/out.log" &
@@ -114,8 +115,9 @@
 			    echo \$!"  > "$PIDFILE"
                 echo "$NAME."
 	else
-                echo "(already running)."
-        fi
+        echo "(already running)."
+		exit 1
+    fi
         ;;
 
   stop)
@@ -132,14 +134,14 @@
 		start-stop-daemon --quiet --stop \
 			--pidfile "$PIDFILE" --user "$JETTY_USER" \
 			--startas "$JAVA" > /dev/null
-                while ! start-stop-daemon --quiet --test --stop \
+                while ! start-stop-daemon --quiet --test --start \
 			--pidfile "$PIDFILE" --user "$JETTY_USER" \
 			--startas "$JAVA" > /dev/null; do 
                         sleep 1
                         echo -n "."
                         JETTY_SHUTDOWN=`expr $JETTY_SHUTDOWN - 1` || true
                         if [ $JETTY_SHUTDOWN -ge 0 ]; then
-				start-stop-daemon --quiet --stop \
+				start-stop-daemon --oknodo --quiet --stop \
 					--pidfile "$PIDFILE" --user "$JETTY_USER" \
 					--startas "$JAVA"
 			else
@@ -184,5 +186,3 @@
 esac
 
 exit 0
-
-

--===============0899362563==--

---------------------------------------
Received: (at 326176-close) by bugs.debian.org; 19 Sep 2005 14:18:16 +0000
>From katie at spohr.debian.org Mon Sep 19 07:18:16 2005
Return-path: <katie at spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
	id 1EHMSA-0005cS-00; Mon, 19 Sep 2005 07:17:06 -0700
From: Philipp Meier <meier at fnogol.de>
To: 326176-close at bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#326176: fixed in jetty 5.1.5rc1-4
Message-Id: <E1EHMSA-0005cS-00 at spohr.debian.org>
Sender: Archive Administrator <katie at spohr.debian.org>
Date: Mon, 19 Sep 2005 07:17:06 -0700
Delivered-To: 326176-close at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

Source: jetty
Source-Version: 5.1.5rc1-4

We believe that the bug you reported is fixed in the latest version of
jetty, which is due to be installed in the Debian FTP archive:

jetty-extra_5.1.5rc1-4_all.deb
  to pool/contrib/j/jetty/jetty-extra_5.1.5rc1-4_all.deb
jetty_5.1.5rc1-4.diff.gz
  to pool/contrib/j/jetty/jetty_5.1.5rc1-4.diff.gz
jetty_5.1.5rc1-4.dsc
  to pool/contrib/j/jetty/jetty_5.1.5rc1-4.dsc
jetty_5.1.5rc1-4_all.deb
  to pool/contrib/j/jetty/jetty_5.1.5rc1-4_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 326176 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Philipp Meier <meier at fnogol.de> (supplier of updated jetty package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri,  2 Sep 2005 13:40:59 +0200
Source: jetty
Binary: jetty-extra jetty
Architecture: source all
Version: 5.1.5rc1-4
Distribution: unstable
Urgency: low
Maintainer: Debian Java Maintainers <pkg-java-maintainers at lists.alioth.debian.org>
Changed-By: Philipp Meier <meier at fnogol.de>
Description: 
 jetty      - Java servlet engine and webserver
 jetty-extra - Extensions to jetty
Closes: 326176
Changes: 
 jetty (5.1.5rc1-4) unstable; urgency=low
 .
   Patch from Oyvind Harboe <oyvind.harboe at zylin.com>:
 .
   * Fixed rc script /etc/init.d/jetty. "stop" could leave dangling
     /var/run/jetty.pid. Fixed this by adding "--oknodo" to
     "start-stop-daemon --stop" command.
   * Removed trailing "/" from LOGDIR which caused
     /var/log/out.log not to be created.
   * /etc/init.d/jetty start will now deal more gracefully with a
     dangling /var/run/jetty.pid. A dangling jetty.pid is detected
     and ignored.
   * Closes: #326176.
Files: 
 ad59e65bd119af288a266d02afad1a12 844 contrib/web optional jetty_5.1.5rc1-4.dsc
 7beb4a48f4587ba99976cf107c6df518 15491 contrib/web optional jetty_5.1.5rc1-4.diff.gz
 4c8d0e7ca8ba9a17b5b340ed26cf6475 1973954 contrib/web optional jetty_5.1.5rc1-4_all.deb
 c109b2dee4f83e5de58c6e53aa17ffd7 792222 contrib/web optional jetty-extra_5.1.5rc1-4_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDLsaF4vzFZu62tMIRAmAIAKCJL1pNpWG8PdKvk8VwQRCq+uNrRwCgjSHl
/48K/kYZ+trAtHJdDqS/Aa0=
=/0Bi
-----END PGP SIGNATURE-----




More information about the pkg-java-maintainers mailing list