Bug#342623: Patch does not seem to remediate the issue identified

[Barry Hawkins]

tags 342623 -patch
stop

Andreas,
    Thank you for your bug report and patch.  I have applied the patch
and tested it, and the addition of quotes to the [ -z ] test does not
seem to correct the issue you have identified with passing a string
containing one or more space characters:

$ less /usr/bin/make-jpkg
[...]
# If a default has been set for either of the
# environment variables, use it; otherwise, 
# default to the name and email used by the 
# Debian Java Maintainers project.
if [ -z "$J2SE_PACKAGE_FULL_NAME" ]; then
    maintainer_name="Debian Java Maintainers"
else
    maintainer_name="$J2SE_PACKAGE_FULL_NAME"
fi
[...]

$ fakeroot make-jpkg --full-name John Doe --email john at example.com
ibm-java2-sdk-50-linux-i386.tgz 
make-jpkg: missing pathname
Try `make-jpkg --help' for more information.

    This phenomenon is not uncommon in my experience; the workaround I
usually apply is either to enclose the argument's value in quotes or to
precede the space with the "\" character:

$ fakeroot make-jpkg --full-name "John Doe" --email john at example.com
ibm-java2-sdk-50-linux-i386.tgz 
Creating temporary directory: /tmp/make-jpkg.XXXX4AfaaL
Loading plugins: blackdown-j2re.sh blackdown-j2sdk.sh common.sh
ibm-j2re.sh ibm-j2sdk.sh j2re.sh j2sdk-doc.sh j2sdk.sh j2se.sh
sun-j2re.sh sun-j2sdk-doc.sh sun-j2sdk.sh

Detected product:
    Java(TM) Software Development Kit (J2SDK)
    Standard Edition, Version 1.5.0
    IBM Corporation
Is this correct [Y/n]: 
[...]

$ fakeroot make-jpkg --full-name John\ Doe --email john at example.com
ibm-java2-sdk-50-linux-i386.tgz 
Creating temporary directory: /tmp/make-jpkg.XXXX83op4b
Loading plugins: blackdown-j2re.sh blackdown-j2sdk.sh common.sh
ibm-j2re.sh ibm-j2sdk.sh j2re.sh j2sdk-doc.sh j2sdk.sh j2se.sh
sun-j2re.sh sun-j2sdk-doc.sh sun-j2sdk.sh

Detected product:
    Java(TM) Software Development Kit (J2SDK)
    Standard Edition, Version 1.5.0
    IBM Corporation
Is this correct [Y/n]: 
[...]

    If you have any other techniques for handling these parameters and
would like to submit them, please do.

Regards,
-- 
Barry Hawkins
All Things Computed
site: www.alltc.com
weblog: www.yepthatsme.com

Registered Linux User #368650

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.alioth.debian.org/pipermail/pkg-java-maintainers/attachments/20060205/c7b79ab4/attachment.pgp