Bug#506782: Patch 81_prevent-network-access.dpatch is not needed anymore

[Onkar Shinde]

On Wed, Nov 26, 2008 at 6:30 PM, Rene Engelhard <rene at debian.org> wrote:
> severity 506782 minor
> thanks
>
> Hi,
>
> Onkar Shinde wrote:
>> Package: lucene2
>> Version: 2.4.0+ds1-1
>
> Why is this a normal bug? ;-)

I wasn't sure of the priority.

>> In file contrib/highlighter/src/test/org/apache/lucene/search/highlight/HighlighterTest.java,
>> the xml snippet in the text testEncoding does not have reference to a
>> DTD anymore. So this unit test does not need any network access to
>> execute.
>>
>> Hence patch 81_prevent-network-access.dpatch is not needed anymore.
>
> But it doesn't do harm, does it?

It bypasses a unit test. Do you consider that serious?
Previously it couldn't run the unit test at all due to network access
required. So I guess it was ok to bypass it to fix build failure. But
now that unit test does not need network access, I think it is not
wise to bypass the unit test.


Onkar