Bug#558121: tomcat6: Extra components missing from package

[Marc Fournier]

> Marc Fournier wrote:
> > The package is currently missing the "extra components" (currently a
> > complete commons-logging implementation
> 
> That sounds like code duplication. It is supposedly a package-renamed
> version of Commons Logging?

I'm not sure. Maybe there could also be some stuff borrowed from log4j. I
fell into this problem following these instructions:
http://tomcat.apache.org/tomcat-6.0-doc/logging.html#log4j

Apparently the source code shipped in both packages is different:

$ apt-get source tomcat6 libcommons-logging-java
[...]
$ diff -r -q tomcat6-6.0.20/java/org/apache/juli/logging/ libcommons-logging-java-1.1.1/src/java/org/apache/commons/logging/ 
Only in tomcat6-6.0.20/java/org/apache/juli/logging/: DirectJDKLog.java
Only in libcommons-logging-java-1.1.1/src/java/org/apache/commons/logging/: impl
Files tomcat6-6.0.20/java/org/apache/juli/logging/LogConfigurationException.java and libcommons-logging-java-1.1.1/src/java/org/apache/commons/logging/LogConfigurationException.java differ
Files tomcat6-6.0.20/java/org/apache/juli/logging/LogFactory.java and libcommons-logging-java-1.1.1/src/java/org/apache/commons/logging/LogFactory.java differ
Files tomcat6-6.0.20/java/org/apache/juli/logging/Log.java and libcommons-logging-java-1.1.1/src/java/org/apache/commons/logging/Log.java differ
Only in libcommons-logging-java-1.1.1/src/java/org/apache/commons/logging/: LogSource.java
Files tomcat6-6.0.20/java/org/apache/juli/logging/package.html and libcommons-logging-java-1.1.1/src/java/org/apache/commons/logging/package.html differ

On the other hand, both tomcat6-6.0.20/{build,extras}.xml (and incidently
tomcat6-6.0.20/debian/rules) seem to download quite a few files. So I'm not
really sure what ends up in the package once it's built.


> > and support for JSR 109)
> > described on this page:
> >   http://tomcat.apache.org/tomcat-6.0-doc/extras.html
> 
> That page says it is licensed under CPL 1.0, which might be a problem.

Apparently CPL is approved by OSI as well as FSF, but I'm no licence
expert... Could it be a problem for Debian if it isn't for the Apache
Fondation ?

In any case, as with Commons Logging, the files seem to be downloaded by
ANT, not shipped in the source package.

Cheers,
Marc