Bug#586781: /usr/bin/jabref outputs warning if openjdk6 is missing

[Onkar Shinde]

On Tue, Jun 22, 2010 at 8:54 PM, gregor herrmann <gregoa at debian.org> wrote:
> On Tue, 22 Jun 2010 16:29:42 +0200, Martin Lutz wrote:
>
>> the startup script /usr/bin/jabref contains the line
>>
>> find_java_runtime openjdk6 || find_java_runtime sun6
>>
>> if the first find_java_runtime fails, a warning is given,
>> even if the second part is successful (sun6 is installed).
>>
>> The warning is confusing:
>> [warning] /usr/bin/jabref: No java runtime was found
>
> I agree that this output is confusing.
>
> Since it comes from /usr/lib/java-wrappers/java-wrappers.sh I guess
> it should be improved there.
>
> Vincent, what do you think about changing the line to something like
>    java_warning "No java runtime for argument '$1' was found"
> ?

I think the usage of find_java_runtime is not preferred way. As per
the comment in /usr/lib/java-wrappers/java-wrappers.sh,

# More than one argument can be specified; they will be taken into account
# in that order; the first one found will be selected.

So ideally it should be 'find_java_runtime openjdk6 sun6'. This way
the first runtime found will be used and there won't be any warning.


Onkar