Bug#761548: Regression caused by maven-bundle-plugin/2.3.7

[Emmanuel Bourg]

The update of maven-bundle-plugin to the version 2.3.7 has caused build
failures on javamail (#761548) and sisu-guice (#761522). After reverting
to the version 2.3.5 they both build fine.

For javamail, I checked out a clean copy of the upstream source,
upgraded maven-bundle-plugin to 2.3.7 in the pom and built directly with
Maven. It worked fine, so the upgrade to 2.3.7 alone isn't enough to
explain the issue, something else specific to the Debian packaging is
involved.

After investigating the maven-bundle-plugin change history it seems this
regression was caused by the fix for FELIX-3165 [1][2]. Restoring these
lines in the ManifestPlugin.execute() method fixed the issue for
javamail and sisu-guice:

    if ( supportedProjectTypes.contains(
getProject().getArtifact().getType() ) )
    {
        Builder builder = buildOSGiBundle( project, instructions,
properties, classpath );
        manifest = builder.getJar().getManifest();
        builder.close();
    }
    else
    {
        manifest = getManifest( project, instructions, properties,
classpath );
    }

I'm going to patch maven-bundle-plugin and restore the old behaviour
when a Debian specific system property is set.

Emmanuel Bourg


[1] https://issues.apache.org/jira/browse/FELIX-3165
[2] https://svn.apache.org/r1184887

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-java-maintainers/attachments/20141003/a3b93668/attachment-0001.sig>