Bug#789518: wagon2: FTBFS in sid

[Emmanuel Bourg]

I got a look too, and this issue is a real mystery.

The error occurs when the tests for wagon-file are executed. I thought
it was caused by the upgrade of maven-surefire-plugin to the version
2.17 in June, but reverting to the version 2.10 from Jessie produces the
same error, and the latest version 2.18.1 doesn't work better.

The error 'ClassNotFoundException:
org.apache.xbean.asm5.original.commons.EmptyVisitor' means that
xbean-asm5-shaded is not on the classpath. wagon-file has the following
dependency graph:

org.apache.maven.wagon:wagon-file:jar:2.7
+- commons-lang:commons-lang:jar:debian:compile
+- org.apache.maven.wagon:wagon-provider-api:jar:2.7:compile
|  \- org.codehaus.plexus:plexus-utils:jar:debian:compile
+- org.apache.maven.wagon:wagon-provider-test:jar:2.7:test
|  +- org.codehaus.plexus:plexus-container-default:jar:debian:test
|  |  +- org.codehaus.plexus:plexus-classworlds:jar:debian:test
|  |  +- org.apache.xbean:xbean-reflect:jar:debian:test
|  |  \- com.google.guava:guava:jar:debian:test
|  +- org.easymock:easymock:jar:debian:test
|  |  +- cglib:cglib:jar:3.x:test
|  |  +- org.ow2.asm:asm:jar:4.x:test
|  |  \- org.objenesis:objenesis:jar:debian:test
|  +- org.mortbay.jetty:jetty:jar:6.x:test
|  |  +- org.mortbay.jetty:jetty-util:jar:6.x:test
|  |  \- javax.servlet:servlet-api:jar:2.5:test
|  \- log4j:log4j:jar:1.2.x:test
\- junit:junit:jar:4.x:test
   \- org.hamcrest:hamcrest-core:jar:debian:test

The graph contains xbean-reflect, and xbean-asm5-shaded is an
optional/provided dependency of xbean-reflect (this relation hasn't
changed since the versions in Jessie). Both artifacts are in the same
package (libxbean-java), so when xbean-reflect is used in a Maven
project xbean-asm5-shaded should always be loaded in the classpath,
because these artifacts are always installed together. But now for some
reason it doesn't happen, xbean-asm5-shaded is ignored.

Removing the optional and provided flags for the xbean-asm5-shaded
dependency in the xbean-reflect pom solves the issue, but I still fail
to understand what change triggered this issue.

Emmanuel Bourg