Patching JXGrabKey

Gilles Filippini pini at debian.org
Wed Jul 6 21:15:03 UTC 2016


Hi,

Mikhail T. a écrit le 30/06/2016 à 15:37 :
> Hello!
> 
> I just added a port of JXGrabKey
> <http://www.freshports.org/java/jxgrabkey> to FreeBSD's port collection
> and one of the patches I found necessary worries me.
> 
> Although I filed a ticket with the original author
> <https://sourceforge.net/p/jxgrabkey/bugs/12/>, I doubt I'll get a quick
> response -- the last release was 6 years ago. This is why I'm asking you
> for a review. The patch itself can be found here
> <https://svnweb.freebsd.org/ports/head/java/jxgrabkey/files/patch-warnings?revision=417813&view=markup>
> and it is the second hunk, that worries me. The first and the third are
> largely cosmetic, but the change from NULL (0) to PTHREAD_PROCESS_SHARED
> (1) changes the semantics. And yet, the author's self-test hangs without
> it here.
> 
> If I'm right, you may wish to update your ports as well. If not -- well,
> I'd appreciate feedback. Thank you! Yours,

From the answers on the report ticket [1], this might not be that
simple. I'd rather wait until this is worked out.

[1] https://sourceforge.net/p/jxgrabkey/bugs/12/

Thanks,

_g.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-java-maintainers/attachments/20160706/268bbd4e/attachment.sig>


More information about the pkg-java-maintainers mailing list