Bug#1026666: Please make liblog4j2-java depend on junit5

[Pierre Gruet]

Hi again tony,

Le 22/12/2022 à 16:16, tony mancill a écrit :
> Hi Pierre,
> 
> On Thu, Dec 22, 2022 at 07:31:30AM +0100, Pierre Gruet wrote:
>> Hi tony,
>>
>> Le 21/12/2022 à 22:58, tony mancill a écrit :
>>> On Tue, Dec 20, 2022 at 11:45:54PM +0100, Pierre Gruet wrote:
>>>> Control: retitle -1 Please make liblog4j2-java depend on junit5
>>>>
>>>> Hello,
>>>>
>>>> In version 2.19.0-1 of liblog4j2-java, the file
>>>> 	/usr/share/maven-repo/org/apache/logging/log4j/log4j/debian/log4j-debian.pom
>>>> declares the junit-bom artifact as a dependency. It is shipped in junit5.
>>>>
>>>> If this dependency is not added, reverse dependencies of liglog4j2-java fail
>>>> to build (see logs above) as the junit-bom artifact is not found.
>>>
>>> Hi Pierre,
>>>
>>> I'm wondering if it wouldn't better to remove junit-bom from log4j pom.
>>> I don't believe we actually need junit5 at runtime for log4j2, so
>>> packages depending on liblog4j2-java should not have to install junit5.
>>>
>>> Any concerns with taking that approach and addressing the bug by
>>> adjusting the pom shipped with liblog4j2-java?
>>
>> Thanks for having a look; I haven't looked further but I also fail to
>> imagine why junit5 would be needed, so I agree with the proposed fix!
> 
> I am spot-checking a few of the reverse dependencies now and will upload
> today.  Thank you for identifying the root cause for this set of build
> failures.
> 

Glad I could help! THanks for taking care of the fix.
If I may help in any way, please tell me :)

> Cheers,
> tony

Best,

-- 
Pierre
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-java-maintainers/attachments/20221222/421a3148/attachment.sig>