[Pkg-javascript-commits] [node-is-glob] 01/04: New upstream version 4.0.0

Praveen Arimbrathodiyil praveen at moszumanska.debian.org
Fri Dec 15 17:05:09 UTC 2017


This is an automated email from the git hooks/post-receive script.

praveen pushed a commit to branch master
in repository node-is-glob.

commit 5333cb4cdb0a259e87eac81caba9cffba9a1c894
Author: Pirate Praveen <praveen at debian.org>
Date:   Sun Oct 22 10:26:42 2017 +0530

    New upstream version 4.0.0
---
 .gitignore   |   9 +++-
 .travis.yml  |   8 ++++
 .verb.md     |  51 ++++++++++++++++++++-
 LICENSE      |   2 +-
 README.md    |  81 ++++++++++++++++++++++++++++------
 appveyor.yml |  28 ++++++++++++
 index.js     |  43 +++++++++++++-----
 package.json |  13 +++---
 test.js      | 142 ++++++++++++++++++++++++++++++++++++++++++++++-------------
 9 files changed, 312 insertions(+), 65 deletions(-)

diff --git a/.gitignore b/.gitignore
index 7988154..f2a4ab2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,16 +6,23 @@
 test/actual
 actual
 coverage
+.nyc*
 
 # npm
 node_modules
 npm-debug.log
 
+# yarn
+yarn.lock
+yarn-error.log
+
 # misc
 _gh_pages
-benchmark
+_draft
+_drafts
 bower_components
 vendor
 temp
 tmp
 TODO.md
+package-lock.json
\ No newline at end of file
diff --git a/.travis.yml b/.travis.yml
index 57b4b01..67decb2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,6 +1,14 @@
 sudo: false
+os:
+  - linux
+  - osx
 language: node_js
 node_js:
+  - node
+  - '8'
+  - '7'
   - '6'
+  - '5'
   - '4'
   - '0.12'
+  - '0.10'
diff --git a/.verb.md b/.verb.md
index dcee8c4..7e8c9d1 100644
--- a/.verb.md
+++ b/.verb.md
@@ -6,6 +6,8 @@ You might also be interested in [is-valid-glob][] and [has-glob][].
 var isGlob = require('{%= name %}');
 ```
 
+### Default behavior
+
 **True**
 
 Patterns that have glob characters or regex patterns will return `true`:
@@ -18,7 +20,6 @@ isGlob('abc/*.js');
 isGlob('abc/(aaa|bbb).js');
 isGlob('abc/[a-z].js');
 isGlob('abc/{a,b}.js');
-isGlob('abc/?.js');
 //=> true
 ```
 
@@ -50,7 +51,6 @@ isGlob('abc/\\*.js');
 isGlob('abc/\\(aaa|bbb).js');
 isGlob('abc/\\[a-z].js');
 isGlob('abc/\\{a,b}.js');
-isGlob('abc/\\?.js');
 //=> false
 ```
 
@@ -62,6 +62,7 @@ isGlob('abc/def/ghi.js');
 isGlob('foo.js');
 isGlob('abc/@.js');
 isGlob('abc/+.js');
+isGlob('abc/?.js');
 isGlob();
 isGlob(null);
 //=> false
@@ -74,3 +75,49 @@ isGlob(['**/*.js']);
 isGlob(['foo.js']);
 //=> false
 ```
+
+### Option strict
+
+When `options.strict === false` the behavior is less strict in determining if a pattern is a glob. Meaning that
+some patterns that would return `false` may return `true`. This is done so that matching libraries like [micromatch][] have a chance at determining if the pattern is a glob or not.
+
+**True**
+
+Patterns that have glob characters or regex patterns will return `true`:
+
+```js
+isGlob('!foo.js', {strict: false});
+isGlob('*.js', {strict: false});
+isGlob('**/abc.js', {strict: false});
+isGlob('abc/*.js', {strict: false});
+isGlob('abc/(aaa|bbb).js', {strict: false});
+isGlob('abc/[a-z].js', {strict: false});
+isGlob('abc/{a,b}.js', {strict: false});
+//=> true
+```
+
+Extglobs
+
+```js
+isGlob('abc/@(a).js', {strict: false});
+isGlob('abc/!(a).js', {strict: false});
+isGlob('abc/+(a).js', {strict: false});
+isGlob('abc/*(a).js', {strict: false});
+isGlob('abc/?(a).js', {strict: false});
+//=> true
+```
+
+**False**
+
+Escaped globs or extglobs return `false`:
+
+```js
+isGlob('\\!foo.js', {strict: false});
+isGlob('\\*.js', {strict: false});
+isGlob('\\*\\*/abc.js', {strict: false});
+isGlob('abc/\\*.js', {strict: false});
+isGlob('abc/\\(aaa|bbb).js', {strict: false});
+isGlob('abc/\\[a-z].js', {strict: false});
+isGlob('abc/\\{a,b}.js', {strict: false});
+//=> false
+```
\ No newline at end of file
diff --git a/LICENSE b/LICENSE
index fa30c4c..3f2eca1 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2014-2015, Jon Schlinkert.
+Copyright (c) 2014-2017, Jon Schlinkert.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
diff --git a/README.md b/README.md
index 3d99316..7c25229 100644
--- a/README.md
+++ b/README.md
@@ -1,4 +1,4 @@
-# is-glob [![NPM version](https://img.shields.io/npm/v/is-glob.svg?style=flat)](https://www.npmjs.com/package/is-glob) [![NPM downloads](https://img.shields.io/npm/dm/is-glob.svg?style=flat)](https://npmjs.org/package/is-glob) [![Build Status](https://img.shields.io/travis/jonschlinkert/is-glob.svg?style=flat)](https://travis-ci.org/jonschlinkert/is-glob)
+# is-glob [![NPM version](https://img.shields.io/npm/v/is-glob.svg?style=flat)](https://www.npmjs.com/package/is-glob) [![NPM monthly downloads](https://img.shields.io/npm/dm/is-glob.svg?style=flat)](https://npmjs.org/package/is-glob)  [![NPM total downloads](https://img.shields.io/npm/dt/is-glob.svg?style=flat)](https://npmjs.org/package/is-glob) [![Linux Build Status](https://img.shields.io/travis/jonschlinkert/is-glob.svg?style=flat&label=Travis)](https://travis-ci.org/jonschlinkert/i [...]
 
 > Returns `true` if the given string looks like a glob pattern or an extglob pattern. This makes it easy to create code that only uses external modules like node-glob when necessary, resulting in much faster code execution and initialization time, and a better user experience.
 
@@ -18,6 +18,8 @@ You might also be interested in [is-valid-glob](https://github.com/jonschlinkert
 var isGlob = require('is-glob');
 ```
 
+### Default behavior
+
 **True**
 
 Patterns that have glob characters or regex patterns will return `true`:
@@ -30,7 +32,6 @@ isGlob('abc/*.js');
 isGlob('abc/(aaa|bbb).js');
 isGlob('abc/[a-z].js');
 isGlob('abc/{a,b}.js');
-isGlob('abc/?.js');
 //=> true
 ```
 
@@ -62,7 +63,6 @@ isGlob('abc/\\*.js');
 isGlob('abc/\\(aaa|bbb).js');
 isGlob('abc/\\[a-z].js');
 isGlob('abc/\\{a,b}.js');
-isGlob('abc/\\?.js');
 //=> false
 ```
 
@@ -74,6 +74,7 @@ isGlob('abc/def/ghi.js');
 isGlob('foo.js');
 isGlob('abc/@.js');
 isGlob('abc/+.js');
+isGlob('abc/?.js');
 isGlob();
 isGlob(null);
 //=> false
@@ -87,12 +88,58 @@ isGlob(['foo.js']);
 //=> false
 ```
 
+### Option strict
+
+When `options.strict === false` the behavior is less strict in determining if a pattern is a glob. Meaning that
+some patterns that would return `false` may return `true`. This is done so that matching libraries like [micromatch](https://github.com/micromatch/micromatch) have a chance at determining if the pattern is a glob or not.
+
+**True**
+
+Patterns that have glob characters or regex patterns will return `true`:
+
+```js
+isGlob('!foo.js', {strict: false});
+isGlob('*.js', {strict: false});
+isGlob('**/abc.js', {strict: false});
+isGlob('abc/*.js', {strict: false});
+isGlob('abc/(aaa|bbb).js', {strict: false});
+isGlob('abc/[a-z].js', {strict: false});
+isGlob('abc/{a,b}.js', {strict: false});
+//=> true
+```
+
+Extglobs
+
+```js
+isGlob('abc/@(a).js', {strict: false});
+isGlob('abc/!(a).js', {strict: false});
+isGlob('abc/+(a).js', {strict: false});
+isGlob('abc/*(a).js', {strict: false});
+isGlob('abc/?(a).js', {strict: false});
+//=> true
+```
+
+**False**
+
+Escaped globs or extglobs return `false`:
+
+```js
+isGlob('\\!foo.js', {strict: false});
+isGlob('\\*.js', {strict: false});
+isGlob('\\*\\*/abc.js', {strict: false});
+isGlob('abc/\\*.js', {strict: false});
+isGlob('abc/\\(aaa|bbb).js', {strict: false});
+isGlob('abc/\\[a-z].js', {strict: false});
+isGlob('abc/\\{a,b}.js', {strict: false});
+//=> false
+```
+
 ## About
 
 ### Related projects
 
 * [assemble](https://www.npmjs.com/package/assemble): Get the rocks out of your socks! Assemble makes you fast at creating web projects… [more](https://github.com/assemble/assemble) | [homepage](https://github.com/assemble/assemble "Get the rocks out of your socks! Assemble makes you fast at creating web projects. Assemble is used by thousands of projects for rapid prototyping, creating themes, scaffolds, boilerplates, e-books, UI components, API documentation, blogs, building websit")
-* [base](https://www.npmjs.com/package/base): base is the foundation for creating modular, unit testable and highly pluggable node.js applications, starting… [more](https://github.com/node-base/base) | [homepage](https://github.com/node-base/base "base is the foundation for creating modular, unit testable and highly pluggable node.js applications, starting with a handful of common methods, like `set`, `get`, `del` and `use`.")
+* [base](https://www.npmjs.com/package/base): Framework for rapidly creating high quality node.js applications, using plugins like building blocks | [homepage](https://github.com/node-base/base "Framework for rapidly creating high quality node.js applications, using plugins like building blocks")
 * [update](https://www.npmjs.com/package/update): Be scalable! Update is a new, open source developer framework and CLI for automating updates… [more](https://github.com/update/update) | [homepage](https://github.com/update/update "Be scalable! Update is a new, open source developer framework and CLI for automating updates of any kind in code projects.")
 * [verb](https://www.npmjs.com/package/verb): Documentation generator for GitHub projects. Verb is extremely powerful, easy to use, and is used… [more](https://github.com/verbose/verb) | [homepage](https://github.com/verbose/verb "Documentation generator for GitHub projects. Verb is extremely powerful, easy to use, and is used on hundreds of projects of all sizes to generate everything from API docs to readmes.")
 
@@ -100,22 +147,30 @@ isGlob(['foo.js']);
 
 Pull requests and stars are always welcome. For bugs and feature requests, [please create an issue](../../issues/new).
 
+### Contributors
+
+| **Commits** | **Contributor** |  
+| --- | --- |  
+| 47 | [jonschlinkert](https://github.com/jonschlinkert) |  
+| 1  | [doowb](https://github.com/doowb) |  
+| 1  | [tuvistavie](https://github.com/tuvistavie) |  
+
 ### Building docs
 
-_(This document was generated by [verb-generate-readme](https://github.com/verbose/verb-generate-readme) (a [verb](https://github.com/verbose/verb) generator), please don't edit the readme directly. Any changes to the readme must be made in [.verb.md](.verb.md).)_
+_(This project's readme.md is generated by [verb](https://github.com/verbose/verb-generate-readme), please don't edit the readme directly. Any changes to the readme must be made in the [.verb.md](.verb.md) readme template.)_
 
-To generate the readme and API documentation with [verb](https://github.com/verbose/verb):
+To generate the readme, run the following command:
 
 ```sh
-$ npm install -g verb verb-generate-readme && verb
+$ npm install -g verbose/verb#dev verb-generate-readme && verb
 ```
 
 ### Running tests
 
-Install dev dependencies:
+Running and reviewing unit tests is a great way to get familiarized with a library and its API. You can install dependencies and run tests with the following command:
 
 ```sh
-$ npm install -d && npm test
+$ npm install && npm test
 ```
 
 ### Author
@@ -123,13 +178,13 @@ $ npm install -d && npm test
 **Jon Schlinkert**
 
 * [github/jonschlinkert](https://github.com/jonschlinkert)
-* [twitter/jonschlinkert](http://twitter.com/jonschlinkert)
+* [twitter/jonschlinkert](https://twitter.com/jonschlinkert)
 
 ### License
 
-Copyright © 2016, [Jon Schlinkert](https://github.com/jonschlinkert).
-Released under the [MIT license](https://github.com/jonschlinkert/is-glob/blob/master/LICENSE).
+Copyright © 2017, [Jon Schlinkert](https://github.com/jonschlinkert).
+Released under the [MIT License](LICENSE).
 
 ***
 
-_This file was generated by [verb-generate-readme](https://github.com/verbose/verb-generate-readme), v0.1.30, on September 03, 2016._
\ No newline at end of file
+_This file was generated by [verb-generate-readme](https://github.com/verbose/verb-generate-readme), v0.6.0, on August 07, 2017._
\ No newline at end of file
diff --git a/appveyor.yml b/appveyor.yml
new file mode 100644
index 0000000..7a9cd56
--- /dev/null
+++ b/appveyor.yml
@@ -0,0 +1,28 @@
+# Test against this version of Node.js
+environment:
+  matrix:
+    # node.js
+    - nodejs_version: "8.0"
+    - nodejs_version: "7.0"
+    - nodejs_version: "6.0"
+    - nodejs_version: "4.0"
+    - nodejs_version: "0.12"
+    - nodejs_version: "0.10"
+
+# Install scripts. (runs after repo cloning)
+install:
+  # Get the latest stable version of Node.js or io.js
+  - ps: Install-Product node $env:nodejs_version
+  # install modules
+  - npm install
+
+# Post-install test scripts.
+test_script:
+  # Output useful info for debugging.
+  - node --version
+  - npm --version
+  # run tests
+  - npm test
+
+# Don't actually build.
+build: off
diff --git a/index.js b/index.js
index e348819..711b8b2 100644
--- a/index.js
+++ b/index.js
@@ -1,23 +1,46 @@
 /*!
  * is-glob <https://github.com/jonschlinkert/is-glob>
  *
- * Copyright (c) 2014-2016, Jon Schlinkert.
- * Licensed under the MIT License.
+ * Copyright (c) 2014-2017, Jon Schlinkert.
+ * Released under the MIT License.
  */
 
 var isExtglob = require('is-extglob');
+var chars = { '{': '}', '(': ')', '[': ']'};
 
-module.exports = function isGlob(str) {
-  if (!str || typeof str !== 'string') {
+module.exports = function isGlob(str, options) {
+  if (typeof str !== 'string' || str === '') {
     return false;
   }
 
-  if (isExtglob(str)) return true;
-  var m, matches = [];
+  if (isExtglob(str)) {
+    return true;
+  }
+
+  var regex = /\\(.)|(^!|\*|[\].+)]\?|\[[^\\\]]+\]|\{[^\\}]+\}|\(\?[:!=][^\\)]+\)|\([^|]+\|[^\\)]+\))/;
+  var match;
+
+  // optionally relax regex
+  if (options && options.strict === false) {
+    regex = /\\(.)|(^!|[*?{}()[\]]|\(\?)/;
+  }
+
+  while ((match = regex.exec(str))) {
+    if (match[2]) return true;
+    var idx = match.index + match[0].length;
+
+    // if an open bracket/brace/paren is escaped,
+    // set the index to the next closing character
+    var open = match[1];
+    var close = open ? chars[open] : null;
+    if (open && close) {
+      var n = str.indexOf(close, idx);
+      if (n !== -1) {
+        idx = n + 1;
+      }
+    }
 
-  while ((m = /(\\).|([*?]|\[.*\]|\{.*\}|\(.*\|.*\)|^!)/g.exec(str))) {
-    if (m[2]) matches.push(m[2]);
-    str = str.slice(m.index + m[0].length);
+    str = str.slice(idx);
   }
-  return matches.length > 0;
+  return false;
 };
diff --git a/package.json b/package.json
index 7d983e3..8d95d4a 100644
--- a/package.json
+++ b/package.json
@@ -1,12 +1,13 @@
 {
   "name": "is-glob",
   "description": "Returns `true` if the given string looks like a glob pattern or an extglob pattern. This makes it easy to create code that only uses external modules like node-glob when necessary, resulting in much faster code execution and initialization time, and a better user experience.",
-  "version": "3.0.0",
+  "version": "4.0.0",
   "homepage": "https://github.com/jonschlinkert/is-glob",
   "author": "Jon Schlinkert (https://github.com/jonschlinkert)",
   "contributors": [
-    "Daniel Perez <daniel at claudetech.com> (http://tuvistavie.com)",
-    "Jon Schlinkert <jon.schlinkert at sellside.com> (http://twitter.com/jonschlinkert)"
+    "Brian Woodward (https://twitter.com/doowb)",
+    "Daniel Perez (https://tuvistavie.com)",
+    "Jon Schlinkert (http://twitter.com/jonschlinkert)"
   ],
   "repository": "jonschlinkert/is-glob",
   "bugs": {
@@ -14,9 +15,7 @@
   },
   "license": "MIT",
   "files": [
-    "index.js",
-    "LICENSE",
-    "README.md"
+    "index.js"
   ],
   "main": "index.js",
   "engines": {
@@ -26,7 +25,7 @@
     "test": "mocha"
   },
   "dependencies": {
-    "is-extglob": "^2.0.0"
+    "is-extglob": "^2.1.1"
   },
   "devDependencies": {
     "gulp-format-md": "^0.1.10",
diff --git a/test.js b/test.js
index bc78b39..4fcae29 100644
--- a/test.js
+++ b/test.js
@@ -13,13 +13,16 @@ var isGlob = require('./');
 
 describe('isGlob', function() {
   describe('glob patterns', function() {
-    it('should return `true` if it is a glob pattern:', function() {
+    it('should be true if it is a glob pattern:', function() {
+      assert(!isGlob('@.(?abc)'), 'invalid pattern');
       assert(isGlob('*.js'));
       assert(isGlob('!*.js'));
       assert(isGlob('!foo'));
       assert(isGlob('!foo.js'));
       assert(isGlob('**/abc.js'));
       assert(isGlob('abc/*.js'));
+      assert(isGlob('@.(?:abc)'));
+      assert(isGlob('@.(?!abc)'));
     });
 
     it('should not match escaped globs', function() {
@@ -32,19 +35,25 @@ describe('isGlob', function() {
       assert(!isGlob('abc/\\*.js'));
     });
 
-    it('should return `false` if the value is not a string:', function() {
+    it('should be false if the value is not a string:', function() {
       assert(!isGlob());
       assert(!isGlob(null));
       assert(!isGlob(['**/*.js']));
       assert(!isGlob(['foo.js']));
     });
 
-    it('should return `false` if it is not a glob pattern:', function() {
+    it('should be false if it is not a glob pattern:', function() {
       assert(!isGlob(''));
+      assert(!isGlob('~/abc'));
+      assert(!isGlob('~/abc'));
+      assert(!isGlob('~/(abc)'));
       assert(!isGlob('+~(abc)'));
       assert(!isGlob('.'));
       assert(!isGlob('@.(abc)'));
       assert(!isGlob('aa'));
+      assert(!isGlob('who?'));
+      assert(!isGlob('why!?'));
+      assert(!isGlob('where???'));
       assert(!isGlob('abc!/def/!ghi.js'));
       assert(!isGlob('abc.js'));
       assert(!isGlob('abc/def/!ghi.js'));
@@ -53,36 +62,80 @@ describe('isGlob', function() {
   });
 
   describe('regex capture groups', function() {
-    it('should return `true` if the path has a capture group (parens):', function() {
+    it('should be true if the path has a regex capture group:', function() {
+      assert(isGlob('abc/(?!foo).js'));
+      assert(isGlob('abc/(?:foo).js'));
+      assert(isGlob('abc/(?=foo).js'));
       assert(isGlob('abc/(a|b).js'));
       assert(isGlob('abc/(a|b|c).js'));
+      assert(isGlob('abc/(foo bar)/*.js'), 'not a capture group but has a glob');
     });
 
-    it('should return `false` if the group is not balanced:', function() {
+    it('should be true if the path has parens but is not a valid capture group', function() {
+      assert(!isGlob('abc/(?foo).js'), 'invalid capture group');
+      assert(!isGlob('abc/(a b c).js'), 'unlikely to be a capture group');
+      assert(!isGlob('abc/(ab).js'), 'unlikely to be a capture group');
+      assert(!isGlob('abc/(abc).js'), 'unlikely to be a capture group');
+      assert(!isGlob('abc/(foo bar).js'), 'unlikely to be a capture group');
+    });
+
+    it('should be false if the capture group is imbalanced:', function() {
+      assert(!isGlob('abc/(?ab.js'));
+      assert(!isGlob('abc/(ab.js'));
       assert(!isGlob('abc/(a|b.js'));
       assert(!isGlob('abc/(a|b|c.js'));
     });
 
-    it('should return `false` if the group is escaped:', function() {
+    it('should be false if the group is escaped:', function() {
       assert(!isGlob('abc/\\(a|b).js'));
       assert(!isGlob('abc/\\(a|b|c).js'));
     });
+
+    it('should be true if glob chars exist and `options.strict` is false', function() {
+      assert(isGlob('$(abc)', {strict: false}));
+      assert(isGlob('&(abc)', {strict: false}));
+      assert(isGlob('? (abc)', {strict: false}));
+      assert(isGlob('?.js', {strict: false}));
+      assert(isGlob('abc/(?ab.js', {strict: false}));
+      assert(isGlob('abc/(ab.js', {strict: false}));
+      assert(isGlob('abc/(a|b.js', {strict: false}));
+      assert(isGlob('abc/(a|b|c.js', {strict: false}));
+      assert(isGlob('abc/(foo).js', {strict: false}));
+      assert(isGlob('abc/?.js', {strict: false}));
+      assert(isGlob('abc/[1-3.js', {strict: false}));
+      assert(isGlob('abc/[^abc.js', {strict: false}));
+      assert(isGlob('abc/[abc.js', {strict: false}));
+      assert(isGlob('abc/foo?.js', {strict: false}));
+      assert(isGlob('abc/{abc.js', {strict: false}));
+      assert(isGlob('Who?.js', {strict: false}));
+    });
+
+    it('should be false if the first delim is escaped and options.strict is false:', function() {
+      assert(!isGlob('abc/\\(a|b).js', {strict: false}));
+      assert(!isGlob('abc/(a|b\\).js'));
+      assert(!isGlob('abc/\\(a|b|c).js', {strict: false}));
+      assert(!isGlob('abc/\\(a|b|c.js', {strict: false}));
+      assert(!isGlob('abc/\\[abc].js', {strict: false}));
+      assert(!isGlob('abc/\\[abc.js', {strict: false}));
+
+      assert(isGlob('abc/(a|b\\).js', {strict: false}));
+    });
   });
 
   describe('regex character classes', function() {
-    it('should return `true` if the path has a regex character class:', function() {
+    it('should be true if the path has a regex character class:', function() {
       assert(isGlob('abc/[abc].js'));
       assert(isGlob('abc/[^abc].js'));
       assert(isGlob('abc/[1-3].js'));
     });
 
-    it('should return `false` if the character class is not balanced:', function() {
+    it('should be false if the character class is not balanced:', function() {
       assert(!isGlob('abc/[abc.js'));
       assert(!isGlob('abc/[^abc.js'));
       assert(!isGlob('abc/[1-3.js'));
     });
 
-    it('should return `false` if the character class is escaped:', function() {
+    it('should be false if the character class is escaped:', function() {
       assert(!isGlob('abc/\\[abc].js'));
       assert(!isGlob('abc/\\[^abc].js'));
       assert(!isGlob('abc/\\[1-3].js'));
@@ -90,13 +143,13 @@ describe('isGlob', function() {
   });
 
   describe('brace patterns', function() {
-    it('should return `true` if the path has brace characters:', function() {
+    it('should be true if the path has brace characters:', function() {
       assert(isGlob('abc/{a,b}.js'));
       assert(isGlob('abc/{a..z}.js'));
       assert(isGlob('abc/{a..z..2}.js'));
     });
 
-    it('should return `false` if (basic) braces are not balanced:', function() {
+    it('should be false if (basic) braces are not balanced:', function() {
       assert(!isGlob('abc/\\{a,b}.js'));
       assert(!isGlob('abc/\\{a..z}.js'));
       assert(!isGlob('abc/\\{a..z..2}.js'));
@@ -104,7 +157,14 @@ describe('isGlob', function() {
   });
 
   describe('regex patterns', function() {
-    it('should return `true` if the path has regex characters:', function() {
+    it('should be true if the path has regex characters:', function() {
+      assert(!isGlob('$(abc)'));
+      assert(!isGlob('&(abc)'));
+      assert(!isGlob('Who?.js'));
+      assert(!isGlob('? (abc)'));
+      assert(!isGlob('?.js'));
+      assert(!isGlob('abc/?.js'));
+
       assert(isGlob('!&(abc)'));
       assert(isGlob('!*.js'));
       assert(isGlob('!foo'));
@@ -112,8 +172,6 @@ describe('isGlob', function() {
       assert(isGlob('**/abc.js'));
       assert(isGlob('*.js'));
       assert(isGlob('*z(abc)'));
-      assert(isGlob('? (abc)'));
-      assert(isGlob('?.js'));
       assert(isGlob('[1-10].js'));
       assert(isGlob('[^abc].js'));
       assert(isGlob('[a-j]*[^c]b/c'));
@@ -121,56 +179,78 @@ describe('isGlob', function() {
       assert(isGlob('a/b/c/[a-z].js'));
       assert(isGlob('abc/(aaa|bbb).js'));
       assert(isGlob('abc/*.js'));
-      assert(isGlob('abc/?.js'));
       assert(isGlob('abc/{a,b}.js'));
       assert(isGlob('abc/{a..z..2}.js'));
       assert(isGlob('abc/{a..z}.js'));
     });
 
-    it('should return `false` if regex characters are escaped', function() {
-      assert(!isGlob('abc/\\(aaa|bbb).js'));
-      assert(!isGlob('abc/\\?.js'));
+    it('should be false if regex characters are escaped', function() {
       assert(!isGlob('\\?.js'));
-      assert(!isGlob('\\[abc\\].js'));
       assert(!isGlob('\\[1-10\\].js'));
       assert(!isGlob('\\[^abc\\].js'));
-      assert(!isGlob('\\a/b/c/\\[a-z\\].js'));
       assert(!isGlob('\\[a-j\\]\\*\\[^c\\]b/c'));
+      assert(!isGlob('\\[abc\\].js'));
+      assert(!isGlob('\\a/b/c/\\[a-z\\].js'));
+      assert(!isGlob('abc/\\(aaa|bbb).js'));
+      assert(!isGlob('abc/\\?.js'));
     });
   });
 
   describe('extglob patterns', function() {
-    it('should return `true` if it has an extglob:', function() {
-      assert(isGlob('abc/@(a).js'));
+    it('should be true if it has an extglob:', function() {
       assert(isGlob('abc/!(a).js'));
-      assert(isGlob('abc/+(a).js'));
+      assert(isGlob('abc/!(a|b).js'));
+      assert(isGlob('abc/(ab)*.js'));
+      assert(isGlob('abc/(a|b).js'));
       assert(isGlob('abc/*(a).js'));
+      assert(isGlob('abc/*(a|b).js'));
+      assert(isGlob('abc/+(a).js'));
+      assert(isGlob('abc/+(a|b).js'));
       assert(isGlob('abc/?(a).js'));
+      assert(isGlob('abc/?(a|b).js'));
+      assert(isGlob('abc/@(a).js'));
+      assert(isGlob('abc/@(a|b).js'));
     });
 
-    it('should return `false` if extglob characters are escaped:', function() {
+    it('should be false if extglob characters are escaped:', function() {
+      assert(!isGlob('abc/\\*.js'));
+      assert(!isGlob('abc/\\*\\*.js'));
       assert(!isGlob('abc/\\@(a).js'));
       assert(!isGlob('abc/\\!(a).js'));
       assert(!isGlob('abc/\\+(a).js'));
       assert(!isGlob('abc/\\*(a).js'));
       assert(!isGlob('abc/\\?(a).js'));
+      assert(isGlob('abc/\\@(a|b).js'), 'matches since extglob is not escaped');
+      assert(isGlob('abc/\\!(a|b).js'), 'matches since extglob is not escaped');
+      assert(isGlob('abc/\\+(a|b).js'), 'matches since extglob is not escaped');
+      assert(isGlob('abc/\\*(a|b).js'), 'matches since extglob is not escaped');
+      assert(isGlob('abc/\\?(a|b).js'), 'matches since extglob is not escaped');
+      assert(isGlob('abc/\\@(a\\|b).js'), 'matches since extglob is not escaped');
+      assert(isGlob('abc/\\!(a\\|b).js'), 'matches since extglob is not escaped');
+      assert(isGlob('abc/\\+(a\\|b).js'), 'matches since extglob is not escaped');
+      assert(isGlob('abc/\\*(a\\|b).js'), 'matches since extglob is not escaped');
+      assert(isGlob('abc/\\?(a\\|b).js'), 'matches since extglob is not escaped');
+    });
+
+    it('should not return true for non-extglob parens', function() {
+      assert(!isGlob('C:/Program Files (x86)/'));
     });
 
-    it('should return `true` if it has glob characters and is not a valid path:', function() {
+    it('should be true if it has glob characters and is not a valid path:', function() {
       assert(isGlob('abc/[*].js'));
       assert(isGlob('abc/*.js'));
-      assert(isGlob('abc/?.js'));
     });
 
-    it('should return `false` if it is a valid non-glob path:', function() {
+    it('should be false if it is a valid non-glob path:', function() {
+      assert(!isGlob('abc/?.js'));
       assert(!isGlob('abc/!.js'));
       assert(!isGlob('abc/@.js'));
       assert(!isGlob('abc/+.js'));
     });
   });
 
-  describe('isGlob', function () {
-    it('should return true when the string has an extglob:', function () {
+  describe('isGlob', function() {
+    it('should return true when the string has an extglob:', function() {
       assert(isGlob('?(abc)'));
       assert(isGlob('@(abc)'));
       assert(isGlob('!(abc)'));
@@ -188,7 +268,7 @@ describe('isGlob', function() {
       assert(isGlob('+(abc|xyz)'));
     });
 
-    it('should not match escaped extglobs', function () {
+    it('should not match escaped extglobs', function() {
       assert(!isGlob('\\?(abc)'));
       assert(!isGlob('\\@(abc)'));
       assert(!isGlob('\\!(abc)'));
@@ -201,7 +281,7 @@ describe('isGlob', function() {
       assert(!isGlob('xyz/\\+(abc)/xyz'));
     });
 
-    it('should detect when an glob is in the same pattern as an escaped glob', function () {
+    it('should detect when an glob is in the same pattern as an escaped glob', function() {
       assert(isGlob('\\?(abc|xyz)/xyz'));
       assert(isGlob('\\@(abc|xyz)'));
       assert(isGlob('\\!(abc|xyz)'));

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-javascript/node-is-glob.git



More information about the Pkg-javascript-commits mailing list