[Pkg-javascript-devel] Bug#512915: closed by Ivan Borzenkov <ivan1986 at list.ru> (Done: [libjs-yui] No source code)

Alexander Reichle-Schmehl tolimar at debian.org
Fri Jan 29 14:56:23 UTC 2010


Hi!

* Alexander Reichle-Schmehl <tolimar at debian.org> [100129 14:03]:

> > Maintainer must get scripts from _src_ directory (instead build) and
> > do build from debian/rules.

Small update for this bug:  All js-files seem to be not affected; while
the package does indeed contain some obfuscated JavaScript code, the
corresponding source code is shipped, too.

You can test that with the following shell-magic (I confess it's ugly,
but it works):

for x in $( find build/ -type f -not -name \*.gif -not -name \*.png -exec wc -l {} \;|sort -n -r|grep -- -min.js|awk '{print $2}' ) ; do
  echo "Testing $x" : ;
  orig=$(echo "$x"|sed -e "s/-min.js$/.js/" ) ;
  if [ -f $orig ] ; then
    echo "  File $orig exists and is $(wc -l $orig|awk '{print $1}') lines long" ;
  else echo "File is obfuscated" ; 
  fi ;
done


Looking with find build/ -type f -not -name \*.gif -not -name \*.png -exec wc -l {} \;|sort -n -r
shows that all other JavaScript stuff (not ending at -min.js) is quite
long; to be sure I randomly checked some of the long files, and they all
appear to be proper source code -- don't ask me, why upstream ships some
of his libraries compressed, and some uncompressed.

However, the many (all?) css files are compressed, too, and sadly they
don't have that -min.css, only the compressed css.  It might be possible
to add the real source for them and "build" them with yui-compressor
during package build; so the package would fulfil the dfsg and would be
saved to the upcoming release.


For future release I would propose not to package new revision from
git-checkout, since that contains the real source for all the stuff and
build it from there, instead of shipping the prebuild / pre-compressed
stuff of the official download.

Note:  That might need to package the yui-builder tool, too.


Best Regards,
  Alexander





More information about the Pkg-javascript-devel mailing list