dr at jones.dk
Thu Oct 13 12:11:29 UTC 2011
On 11-10-13 at 01:08pm, Jérémy Lal wrote:
> On 13/10/2011 12:17, Jonas Smedegaard wrote:
> > On 11-10-13 at 11:08am, Jérémy Lal wrote:
> >> Version 1.0.95 (in collab-maint) still needs some work (see TODO in
> >> changelog), but can be built and tested.
> > Great!
> > I will take a look at the copyright file.
> Thank you.
> > A patch 2004_man_gz.patch exist but no series file?!?
> An old one i temporarily kept. Removed.
Worse: Source contains a binary executable. Even though the
accompanying notes state that the source is DFSG-free, but said sources
are not included and we cannot know for sure if they are in fact used.
Also it is statically linked which means it pulls in code from other
sources which is certainly not available. Package should be repackaged
with deps/ subdir stripped.
Non-free TrueType font Gubblebum Blocky is included below html/*/. Also,
all that documentation below html/ sems autogenerated using ronnjs. So
probably html/ should be stripped and instead generated at build time
(with options to avoid that non-free font as needed).
I notice a link to a youtube video in the regression tests. Not sure,
but if any regression tests go online during build, they should be
disabled or patched to not do so.
Since we are mangling upstream source anyway, I suggest to also strip
node_modules/ to ease copyright file maintainance. I looked briefly at
those embedded packages, and even if relatively small, many of them
contain regression tests of their own which should get proper exposure
by packaging them each separately.
I postpone further copyright checking until source have been repackaged
(or you've convinced me it is unneeded ;-) ).
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature