[Pkg-javascript-devel] Bug#622628: Bug#622628: npm ready to be reviewed

[Jonas Smedegaard]

Hi Jérémy,

Excellent, all of those recent changes!

On 12-04-07 at 01:54am, Jérémy Lal wrote:
> > Please use either true upstream URL (at Github) or a 
> > Debian-maintained redirection service to track and download upstream 
> > source (see node-xmpp for an example, using githubredir.debian.net).  
> > The npmjs.org registry is nice but less trustworthy.
> 
> Lot more work to do, but done, see git log (i hope i managed to get 
> something readable this time).

Sensible, yes.  Not sure I like your DEB_UPSTREAM_REPACKAGE_TAG 
resolving (or that it works at all): I'd simple leave it out and 
explicitly declare it if ever needed to be different from the different 
"dfsg".  But that's a minor issue, we can deal with that later...


> NB: Should i list added Build-Depends in changelog ?

Yes, I find that best: Generally all changes reaching the end user 
should be documented in changelog, and changes to package relations sure 
belong in that category.

I've taken the liberty to do that on your behalf, and is now compiling 
the package...


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-javascript-devel/attachments/20120407/540e2ad7/attachment.pgp>